Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#35] Rely on edn/read-string for string parsing #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#35] Rely on edn/read-string for string parsing #36

wants to merge 2 commits into from

Conversation

bn-darindouglass-zz
Copy link
Contributor

@bn-darindouglass-zz bn-darindouglass-zz commented Apr 17, 2020 •
edited
Loading

  • The previous regex checks are redundant given edn/read-string
    provides the same functionality.

Fixes #35

barracudarin and others added 2 commits April 17, 2020 14:21
@barracudarin
[tolitius#35] Rely on edn/read-string for string parsing
b641409 
- The previous regex checks are redundant given `edn/read-string`
  provides the same functionality.
@bn-darindouglass-zz
Merge branch 'master' into 35-fix-str-to-value
2e4b37d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cprop cannot handle setting nils
2 participants
@bn-darindouglass-zz @barracudarin