Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Discuss encoding of Alerts #40

Closed
bemasc opened this issue Feb 17, 2022 · 4 comments
Closed

Request: Discuss encoding of Alerts #40

bemasc opened this issue Feb 17, 2022 · 4 comments

Comments

@bemasc
Copy link
Collaborator

bemasc commented Feb 17, 2022

It’s currently not clear how plaintext Alerts are represented.

Suggestion: content_type = ctls_alert

@hannestschofenig
Copy link
Contributor

I created a PR to address this issue: #47

@ekr
Copy link
Collaborator

ekr commented Mar 7, 2022

@bemasc why can't they just be the usual content type? What am I missing.

@bemasc
Copy link
Collaborator Author

bemasc commented Mar 7, 2022

The current text says

The only cTLS records that are sent in plaintext are handshake
records (ClientHello and ServerHello/HRR). The content type is
therefore constant (it is always handshake), so we instead set the
content_type field to a fixed cTLS-specific value to distinguish cTLS
plaintext records from encrypted records, TLS/DTLS records, and other
protocols using the same 5-tuple.

I'm proposing that:

  1. The first sentence (or maybe the second) is not right.
  2. We need another content_type for plaintext alerts.

I'm not sure what you mean by "the usual content type". cTLS currently does not use TLS's ContentType registry. Instead, the current draft defines a new ctls_handshake value to identify these records.

If you're proposing to switch cTLS to use the TLS ContentTypes instead ... that seems fine to me. However, the divergence does seem to be deliberate, as explained in the text.

@ekr
Copy link
Collaborator

ekr commented Mar 7, 2022

I think this is just an error on my part:

  1. You obviously need to be able to send plaintext alerts.
  2. The requirement is to be able to demux, but if cTLS alerts are the same, then no need

For that reason, I propose to just use TLS's alert type.

ekr added a commit that referenced this issue Mar 7, 2022
ekr added a commit that referenced this issue Mar 7, 2022
Clarify alerts. Fixes issue #40
@ekr ekr closed this as completed Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants