Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Filter button and indicator that list is filtered #20

Open
SamHasler opened this issue Jul 20, 2020 · 3 comments
Open

Add Filter button and indicator that list is filtered #20

SamHasler opened this issue Jul 20, 2020 · 3 comments

Comments

@SamHasler
Copy link

It would be useful to be able to filter by trigger words, so I could e.g. see all @audit-issue or @todo's without all the other bookmarks for other trigger words.

@tintinweb
Copy link
Owner

Hey @SamHasler,

is this different from #14 (comment)?

command -> inline bookmarks: set view filter: a regex that matches your filter (also matches the tag words)

@tintinweb tintinweb added the question Further information is requested label Jul 20, 2020
@SamHasler
Copy link
Author

Ah, hadn't realised that command existed. I was going by the available buttons on the panel.

I guess it would have been helpful if there was a button for it, but having the command is ok for now.

What's really needed is some indication in the UI that the list has been filtered. (I leave my machine on for days so I could come back and not realise it's been filtered at the moment.)

Could we change this issue to be for adding UI to indicate that the current list is filtered, and how. Or close it and I'll raise a separate issue for it if you like.

@tintinweb tintinweb changed the title Filter by trigger word Add Filter button and indicator that list is filtered Jul 24, 2020
@tintinweb tintinweb added feature-request and removed question Further information is requested labels Jul 24, 2020
tintinweb added a commit that referenced this issue Jan 4, 2021
@tintinweb
Copy link
Owner

Added a couple more quick actions.

image

What's really needed is some indication in the UI that the list has been filtered. (I leave my machine on for days so I could come back and not realise it's been filtered at the moment.)

Haven't yet found an easy way to indicate if a filter is active (cannot change the image of the menu button at runtime and there is no generic way to represent an "active"/"pressed" menu button with the vscode API :/). Can only partially address this so far by adding the new set of buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants