-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peaks add calibration #1
base: Peaks-add-calibration
Are you sure you want to change the base?
Peaks add calibration #1
Conversation
Confirmed, this build installs and functions well. Not sure how to specifically test that the calibration code works, but the original and extended functions are working as described. |
Please don't make compiled code available via my repository. I cannot
support code that I have not checked and tested. It's fine for you to
release compiled code, but please do it via your own repository and web
site - that way it is clear that you are responsible for any problems that
binary may cause (such as bricking modules).
Tim C
…On 3 June 2017 at 05:47, Tom Burns ***@***.***> wrote:
I went through this process and ended up with identical code, then
realized the PR already existed.
Attached is the wave file. I'm going to try it tonight.
peaks_calibrated.zip
<https://github.com/timchurches/Mutated-Mutables/files/1048795/peaks_calibrated.zip>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACugYUHGoJphcHppsChIKMQtUSjWtTVSks5sAGbvgaJpZM4MxSsW>
.
|
Ok, sorry. I didn't think an attachment on a PR comment would be considered very official but don't want to cause you support debt. |
Booruns: nice to hear that its working for you. I run this fw on two diy peaks and everything og and dmc is working. Have not been able to do the calibration thou, not on this fw or with oliviers original fw with added calibration code. Is your peaks MI factory? What hw version? Can you do the calibration routine with official fw |
The firmware's working for me but I haven't been able to detect when it enters calibration mode. Looking at the code there's no indication how long calibration takes. I'm thinking perhaps it is faster than what is visible? not sure. |
Ok, I'm finally ready to re-engage with this! I'll test it this weekend.
…----
t
On 12 Jul 2017, at 12:05, Tom Burns ***@***.***> wrote:
The firmware's working for me but I haven't been able to detect when it enters calibration mode.
Looking at the code there's no indication how long calibration takes. I'm thinking perhaps it is faster than what is visible? not sure.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Tim just FYI,
I'm working on bringing the latest peaks changes from upstream into this repo. It sits on top of these changes, but if you're going to do extensive testing only once you may want to wait for this.
WIP branch is here https://github.com/boourns/Mutated-Mutables/commits/Peaks-add-calibration <https://github.com/boourns/Mutated-Mutables/commits/Peaks-add-calibration>
I suspect I'll have it building and tested on my Peaks tonight.
… On Jul 11, 2017, at 10:11 PM, Tim Churches ***@***.***> wrote:
Ok, I'm finally ready to re-engage with this! I'll test it this weekend.
----
t
> On 12 Jul 2017, at 12:05, Tom Burns ***@***.***> wrote:
>
> The firmware's working for me but I haven't been able to detect when it enters calibration mode.
>
> Looking at the code there's no indication how long calibration takes. I'm thinking perhaps it is faster than what is visible? not sure.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqsnpbHGn4buYNEZd7vpqHz-Ffu_3Fkks5sNCtCgaJpZM4MxSsW>.
|
Any pulse left in this? I built a Mutated Peaks with intent to use this firmware without realizing it was v3, so i came here to see if I could take a stab at this when i saw this branch. (although my c++ and arm skills/environment are super rusty) I'm more than willing to spend some afterwork evenings testing if ya want it (launching a couple projects currently for work, so probably an hour or two a couple nights a week for a few months). Just let me know there's still interest, and let me know what branch to test / RC if applicable. |
I would suggest you use #2 <#2>
It is Peaks DMC based against the latest official source. Solves the timing issues that were brought up a few months ago on the Peaks thread on muffwiggler.
… On Oct 15, 2017, at 2:12 PM, Joe ***@***.***> wrote:
Any pulse left in this? I built a Mutated Peaks with intent to use this firmware without realizing it was v3, so i came here to see if I could take a stab at this when i saw this branch. (although my c++ and arm skills/environment are super rusty)
I'm more than willing to spend some afterwork evenings testing if ya want it (launching a couple projects currently for work, so probably an hour or two a couple nights a week for a few months). Just let me know there's still interest, and let me know what branch to test / RC if applicable.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqsno8v854liJAO9Osv4YhZAcWXGevpks5ssksWgaJpZM4MxSsW>.
|
i am new to github so sorry if i just missed it. but where can i get a wav file for the dead mans catch v3 version with calibration? i bought a false module from someone and there is a offset on the outs which annoys me. |
Not tested on peaks hw yet. Will do tonight or the coming days.