From d08b58293b4a289db15ff7562602d5a9e9359ad8 Mon Sep 17 00:00:00 2001 From: ekexium Date: Mon, 13 Nov 2023 14:09:11 +0800 Subject: [PATCH 1/2] comment: fix comment in TimeDetail Signed-off-by: ekexium --- util/execdetails.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/util/execdetails.go b/util/execdetails.go index 3a120c45e6..a98962ad2e 100644 --- a/util/execdetails.go +++ b/util/execdetails.go @@ -609,12 +609,13 @@ type TimeDetail struct { // cannot be excluded for now, like Mutex wait time, which is included in this field, so that // this field is called wall time instead of CPU time. ProcessTime time.Duration - // Cpu wall time elapsed that task is waiting in queue. + // Time elapsed when a coprocessor task yields itself. SuspendTime time.Duration // Off-cpu wall time elapsed in TiKV side. Usually this includes queue waiting time and // other kind of waits in series. WaitTime time.Duration - // KvReadWallTime is the time used in KV Scan/Get. + // KvReadWallTime is the time used in KV Scan/Get. For get/batch_get, + // it also includes the time of spawning and queueing. KvReadWallTime time.Duration // TotalRPCWallTime is Total wall clock time spent on this RPC in TiKV. TotalRPCWallTime time.Duration From 616154c421b330f0ed01d1225babaab8f8c6792e Mon Sep 17 00:00:00 2001 From: ekexium Date: Mon, 13 Nov 2023 15:13:55 +0800 Subject: [PATCH 2/2] comment: refine comment of KvReadWallTime Signed-off-by: ekexium --- util/execdetails.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/execdetails.go b/util/execdetails.go index a98962ad2e..75a5181409 100644 --- a/util/execdetails.go +++ b/util/execdetails.go @@ -615,7 +615,7 @@ type TimeDetail struct { // other kind of waits in series. WaitTime time.Duration // KvReadWallTime is the time used in KV Scan/Get. For get/batch_get, - // it also includes the time of spawning and queueing. + // this is total duration, which is almost the same with grpc duration. KvReadWallTime time.Duration // TotalRPCWallTime is Total wall clock time spent on this RPC in TiKV. TotalRPCWallTime time.Duration