feat(torture): unify exec commit and commit crash

[gabriele-0201]

The unification of the two has the side effect of handling
ENOSPC errors also for commits that are expected to crash.

[gabriele-0201]

• refactor: increment sync_seqn after meta update #809
• feat(torture): unify rollback and rollback crash #792
• feat(torture): rollback handles ENOSPC #791
• feat(torture): unify exec commit and commit crash #790 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[pepyakin]

❗️

Shouldn't we expect, for example, that if the commit succeeded then the sync_seqn should actually be equal to snapshot.sync_seqn?

[gabriele-0201]

Yes, we expected that. The current if-else statement doesn't properly cover all expected and unexpected cases. Now that you've let me think more about that, I will update it with:

        // Sample the agent to make sure the changeset was correctly applied or reverted.
        let agent_sync_seqn = rr.send_query_sync_seqn().await?;
        if snapshot.sync_seqn == agent_sync_seqn {
            // The changeset is expected to be applied, the commit succeeded.
            self.ensure_changeset_applied(&rr, &changeset).await?;
            self.state.commit(snapshot);
        } else if self.state.committed.sync_seqn == agent_sync_seqn {
            // The changeset is expected to be reverted, the commit crashed.
            self.ensure_changeset_reverted(&rr, &changeset).await?;
        } else {
            return Err(anyhow::anyhow!("Unexpected agent sync_seqn"));
        }

[pepyakin]

Merge activity

• Feb 15, 2:32 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Feb 15, 2:33 AM EST: A user merged this pull request with Graphite.