Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo/rollkit: fix the namespaces #188

Merged
merged 1 commit into from
Jan 12, 2024
Merged

demo/rollkit: fix the namespaces #188

merged 1 commit into from
Jan 12, 2024

Conversation

pepyakin
Copy link
Contributor

Set the namespace used for the gm demo that is compatible with the current
version. Specifically, the current version requires to be the version byte
(0th index) be zero and the reserved bytes (1..5th indicies) be zero as well.

Copy link
Contributor Author

pepyakin commented Jan 11, 2024

This was referenced Jan 11, 2024
@pepyakin pepyakin force-pushed the pep-adapters-sov-configurable-timeout branch from b8a2a1e to 70634b1 Compare January 11, 2024 16:43
@pepyakin pepyakin force-pushed the pep-demo-rollkit-fix-ns branch from 3963d90 to f2c94b2 Compare January 11, 2024 16:43
Copy link
Contributor

rphmeier commented Jan 12, 2024

Merge activity

  • Jan 12, 5:25 PM: @rphmeier started a stack merge that includes this pull request via Graphite.
  • Jan 12, 5:28 PM: Graphite rebased this pull request as part of a merge.
  • Jan 12, 5:29 PM: @rphmeier merged this pull request with Graphite.

@rphmeier rphmeier force-pushed the pep-adapters-sov-configurable-timeout branch from 70634b1 to dfbe3c2 Compare January 12, 2024 22:26
Base automatically changed from pep-adapters-sov-configurable-timeout to main January 12, 2024 22:27
Set the namespace used for the gm demo that is compatible with the current
version. Specifically, the current version requires to be the version byte
(0th index) be zero and the reserved bytes (1..5th indicies) be zero as well.
@rphmeier rphmeier force-pushed the pep-demo-rollkit-fix-ns branch from f2c94b2 to 354ef38 Compare January 12, 2024 22:27
@rphmeier rphmeier merged commit b27f736 into main Jan 12, 2024
3 checks passed
@rphmeier rphmeier deleted the pep-demo-rollkit-fix-ns branch January 12, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants