Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: make sure that demos work #54

Open
pepyakin opened this issue Nov 24, 2023 · 0 comments
Open

CI: make sure that demos work #54

pepyakin opened this issue Nov 24, 2023 · 0 comments
Assignees

Comments

@pepyakin
Copy link
Contributor

pepyakin commented Nov 24, 2023

Demos are not in the CI and it's quite cumbersome to run them. Those should be checked in the CI.

It's a bit heavy though, so maybe we should run them only on master commits or maybe as part of merge queue as opposed to for every commit on PR. I think I am OK to break master occasionally for the time being if that improves CI times. When the project is released we should be more strict about that though.

Perhaps, that would require us to write docker-compose files (or maybe something similar). Those would allow us a one-click way to launch the demos, which is useful to do to check stuff locally. Those files can also double as configuration examples should the user want to build their own test environments.

@pepyakin pepyakin added this to the Sugondat Monocore Kusama milestone Dec 4, 2023
@pepyakin pepyakin self-assigned this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant