-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add distanceTo and bearingTo methods to arcTimelineItems #15
Comments
Initial implementation is available at https://github.com/PalminX/arc-data-server/tree/DistanceAndBearing The current implementation uses this to show the distance of a timelineItem to its "place" in the timelineitems/list view. This use case is quite specific and needs to be changed, this should be available through the filter arguments. TODO:
|
This is great! 😄 It's also something I've wanted to build into Arc, for the same purpose (finding mislabelled visits), but haven't had the time to. Great to see it implemented here! |
I see the arc-data-server as a playground to see how the data can be used, and then maybe some of that stuff can later be integrated into Arc |
@PalminX I'm getting loads of
messages in my nodejs console, I guess for Regarding your use cases:
We should definitely describe for which purposes each case is useful. (looking at you #14 👀) |
Yes, these can be removed... these were mainly for debugging. Also, adding the distance and bearing attributes to the /timelineItems/list endpoint was more for testing purposes, not as a final implementation/use of this. Re 1. and 3.:
I haven't really thought this through yet... But the idea was more to use a place name as the reference location, i.e. maybe something like
For now, I don't think it makes sense to use anything other than Places for location references. In the future, a map-based frontend application could of course also use a marker on the map as a reference (useful to filter for a specific region) |
Adding distanceTo and bearingTo methods to arcTimelineItems and to the filters would enable queries like this:
The text was updated successfully, but these errors were encountered: