You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @thminhVN, nice work with on time and clean UI submission 👍
The goals of this homework are:
to know how to implement authentication from scratch in Rails with the help of the has_secure_password class method and the brypt gem (while understanding what they do under the hood)
to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for belongs_to/has_many, using has_many :through and building more advanced queries by chaining where, order, and merge
to build more complex forms in views that involve multiple models.
Quick review:
Clean routes.
Good job with relationship definitions.
Suggestions:
I only see validations password in User. You should validate email and name too. And your new message form to.
You should place login, logout feature in separating controller such as sessions_controller.rb. I will help you managing your code better.
You should check that user already login or not when access message and friend actions. You can use before_action and your helper method current_user for it.
Congrats again on the submission. Everyone has limited time; it's good to see you finish all required functionalities. Let us know if you have any feedback.
@coderschoolreview. It not finish yet. Could I improve some features until 11h59 PM?
The text was updated successfully, but these errors were encountered: