Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My first submission #1

Open
thminhVN opened this issue Mar 21, 2016 · 2 comments
Open

My first submission #1

thminhVN opened this issue Mar 21, 2016 · 2 comments

Comments

@thminhVN
Copy link
Owner

@coderschoolreview. It not finish yet. Could I improve some features until 11h59 PM?

@thminhVN
Copy link
Owner Author

@coderschoolreview. I finished all require tasks :)

@hoksilato
Copy link

Hi @thminhVN, nice work with on time and clean UI submission 👍

The goals of this homework are:

  • to know how to implement authentication from scratch in Rails with the help of the has_secure_password class method and the brypt gem (while understanding what they do under the hood)
  • to design a more complex schema for a web app and be more familiar with ActiveRecord API such as custom foreign keys for belongs_to/has_many, using has_many :through and building more advanced queries by chaining where, order, and merge
  • to build more complex forms in views that involve multiple models.

Quick review:

  • Clean routes.
  • Good job with relationship definitions.

Suggestions:

  • I only see validations password in User. You should validate email and name too. And your new message form to.
  • You should place login, logout feature in separating controller such as sessions_controller.rb. I will help you managing your code better.
  • You should check that user already login or not when access message and friend actions. You can use before_action and your helper method current_user for it.

Congrats again on the submission. Everyone has limited time; it's good to see you finish all required functionalities. Let us know if you have any feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants