Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] sof-test needs to support Fedora 34 #633

Closed
plbossart opened this issue Mar 22, 2021 · 10 comments
Closed

[FEATURE] sof-test needs to support Fedora 34 #633

plbossart opened this issue Mar 22, 2021 · 10 comments
Assignees
Labels
P1 Blocker bugs or important features type:enhancement New framework feature or request

Comments

@plbossart
Copy link
Member

With the transition in Fedora34 from PulseAudio to Pipewire, some of our scripts dealing with PulseAudio need to be updated.

@plbossart plbossart added the type:enhancement New framework feature or request label Mar 22, 2021
@lgirdwood
Copy link
Member

@perexg @jwrdegoede fyi

@perexg
Copy link

perexg commented Mar 24, 2021

Adding Wim to the chain. @wtay

Could you link us to scripts which should be checked / modified?

@lgirdwood
Copy link
Member

We have a lot of test scripts here https://github.com/thesofproject/sof-test/tree/master/test-case and IIIUC they all use the ALSA APIs (i.e. none use any PA APIs) so my expectation is that these should work (or require minimal configuration changes).

I think the largest task is probably to integrate the Jenkins based audio test infrastructure we have to additionally support RPM pagkages. Today, Debian based tooling is used to update kernels, modules and tooling on each DUT and we need to make sure we can support RPM here too on F34 and beyond.

@kv2019i @aiChaoSONG @marc-hb any further comments here ?

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 24, 2021

Agreed: 95% of sof-test should just work on Fedora (please report bugs and/or submit fixes) whereas the Debian packaging of the kernel and ALSA packages is obviously not going to work.

Custom ALSA packages are less often required on Fedora though :-) thesofproject/sof#2543

Related: [RFC] enable sof-test on ChromeOS #576

@plbossart
Copy link
Member Author

plbossart commented Mar 29, 2021

Installing dependencies is straightforward:

dnf install expect python3-graphviz python3-numpy python3-scipy

the rest is less clear:

Checking group memberships:		Warning
Solution:

	Missing permission to run command as sudo

		Please use the following command to add current user to the group sudo:

	 sudo usermod --append --groups sudo 

why is this needed?

	Missing /var/log/kern.log file, which is where we'll catch the kernel log

		Please create the link of your distribution kernel log file at /var/log/kern.log

I thought we are now using journalctl? What is this dependency, is it still needed?

@plbossart
Copy link
Member Author

cut: /var/log/kern.log: No such file or directory
2021-03-29 14:20:32 UTC Sub-Test: [INFO] Test Result: PASS!

fantastic.

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 29, 2021

There are many commands in sof-test that need sudo, starting with inserting and removing modules.

I thought we are now using journalctl? What is this dependency, is it still needed?

It's unfortunately not complete, see internal issue 477 and others.

cut: /var/log/kern.log: No such file or directory [INFO] Test Result: PASS!

#312 should help, it has been implemented on some tests but not others. Does every test "PASS" like this?

The good news is: these are not new issues and not specific to Fedora. The bad news is: all this is down to prioritization. When everything is urgent, nothing is.

@aiChaoSONG
Copy link

aiChaoSONG commented Mar 30, 2021

@plbossart check this ongoing PR, it totally removes /var/log/kern.log, and use journalctl.

Edit: PR #639, @marc-hb thanks.

cut: /var/log/kern.log: No such file or directory

Unfortunately, only Ubuntu use this file

@marc-hb
Copy link
Collaborator

marc-hb commented Mar 30, 2021

I guess @aiChaoSONG is referring to #639

@mengdonglin mengdonglin added the P1 Blocker bugs or important features label Mar 31, 2021
@mengdonglin
Copy link
Contributor

PR #639 was separated to two other PRs #643, #649 that were merged. So sof-test is ready. The remaining work is remove usage of sudo group but to use audio group for all OSes. Close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Blocker bugs or important features type:enhancement New framework feature or request
Projects
None yet
Development

No branches or pull requests

6 participants