Validate body req of webhook and make tagUser optional #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danibonilha
force-pushed
the
dani/remove-required-tag-user
branch
3 times, most recently
from
ba73105 to
d03e12b
Compare
danibonilha
force-pushed
the
dani/remove-required-tag-user
branch
from
d03e12b to
b5c3b6d
Compare
|
Will poke at the tests separately, though that might block deploy post-merge. We'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple validation on the request body of discord's webhook and makes
tagUserparam optional. I've made it default to"0"because I'm assuming n8n sends"0"since there's a check for that, but if that's not the case we could change this just to check if the value is a string, to not blow up while calling.splitwhich I've also changed the placement, bcmemberIdswas not used anywhere else, so it makes more sense to move it.Also it updates the admin list.
Not sure why tests are failing, seems a port issue, maybe it's the worker ?