Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAsyncEnumerable<T> is not included in net48 build #197

Open
ig-sinicyn opened this issue Jul 4, 2023 · 5 comments
Open

IAsyncEnumerable<T> is not included in net48 build #197

ig-sinicyn opened this issue Jul 4, 2023 · 5 comments

Comments

@ig-sinicyn
Copy link

The IAsyncEnumerable interface is not shipped as a part of net48 (see the "Applies to" section).
Theraot.Core does include its own copy but it is excluded for the net48 target, IAsyncEnumerable.cs:

#if LESSTHAN_NET47 || LESSTHAN_NETCOREAPP20 || LESSTHAN_NETSTANDARD20
...

I'm not sure if it was done intentionally, so just a report here:)

@OwnageIsMagic
Copy link
Collaborator

This is intentional not including it when targeting net461+ since otherwise it would conflict with Microsoft.Bcl.AsyncInterfaces from other packages as you already found in a hard way. The fix is to replace LESSTHAN_NET47 with LESSTHAN_NET46.

@NN---
Copy link
Collaborator

NN--- commented Nov 8, 2023

This is intentional not including it when targeting net461+ since otherwise it would conflict with Microsoft.Bcl.AsyncInterfaces from other packages as you already found in a hard way. The fix is to replace LESSTHAN_NET47 with LESSTHAN_NET46.

Want to open a PR?

@OwnageIsMagic
Copy link
Collaborator

It could be done from web editor, but I'm puzzled with current branching policy.

@theraot
Copy link
Owner

theraot commented Nov 8, 2023

The branches got messy for the attempt to add a version 4 which was allowing unsafe. The idea being that whatever restructuring/splitting can happen in develop_v4, and would be v4 once released... Assuming anything of that were to be done.

The bulk of the work remains in develop_v3, and v3 is the last released.

However there are changes in master which would have to be merged on develop_v3, if they don't break anything. And then possibly if to develop_4, if that will be worked on.

That leaves what to do with master afterwards... It could be kept in sync with either develop_v3 or develop_v4, which ever is to be worked primarily, which would also ease pull request going forward.

@NN---
Copy link
Collaborator

NN--- commented Nov 9, 2023

@theraot Can you open discussions page in GitHub ?
@OwnageIsMagic I think we should discuss how to move forward.
There is a branch messing little bit.
There should be one branching policy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants