Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dry run option #230

Open
andy5995 opened this issue Jun 17, 2019 · 2 comments
Open

add dry run option #230

andy5995 opened this issue Jun 17, 2019 · 2 comments

Comments

@andy5995
Copy link
Member

Adding a dry run (-n) option for purge was discussed on IRC today. I think ultimately that would be a good feature. I don't feel a need for it personally because for my workflow, if I have stuff in the trash for 45 or 90 days and haven't missed it, I don't worry that I need to review what will be purged.

But I could see how some users might like that feature and would consider adding it in the future or accepting a PR to add it.

andy5995 added a commit that referenced this issue Jun 18, 2019
enabled with RMWTRASH=dry-run
@andy5995 andy5995 changed the title add dry run option for purge add dry run option Jun 18, 2019
@andy5995
Copy link
Member Author

I added a patch to test this for purging, and plan to implement it for just regular rmw'ing.

@andy5995
Copy link
Member Author

The -n, --dry-run options haven't been added yet but that'll happen before the next release.

@andy5995 andy5995 added this to the 0.7.03 milestone Jun 21, 2019
@andy5995 andy5995 modified the milestones: 0.7.03, 0.7.04 Aug 1, 2019
@andy5995 andy5995 self-assigned this Aug 8, 2019
@andy5995 andy5995 modified the milestones: 0.7.04, 0.7.05 Aug 12, 2019
andy5995 added a commit that referenced this issue Jun 5, 2020
@andy5995 andy5995 modified the milestones: 0.7.05, 0.7.06 Jun 13, 2020
andy5995 added a commit that referenced this issue Aug 27, 2020
@andy5995 andy5995 modified the milestones: 0.7.06, 0.7.07 Feb 25, 2021
@andy5995 andy5995 modified the milestones: 0.7.07, 0.7.08 Apr 7, 2021
@andy5995 andy5995 removed this from the 0.7.08 milestone Apr 28, 2021
zvezdochiot pushed a commit to FS-make-simple/rmw that referenced this issue Sep 5, 2022
zvezdochiot pushed a commit to FS-make-simple/rmw that referenced this issue Sep 5, 2022
zvezdochiot pushed a commit to FS-make-simple/rmw that referenced this issue Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant