Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mediainfo always opening #36

Open
kolbdog3333 opened this issue Jan 3, 2024 · 10 comments
Open

Mediainfo always opening #36

kolbdog3333 opened this issue Jan 3, 2024 · 10 comments

Comments

@kolbdog3333
Copy link

kolbdog3333 commented Jan 3, 2024

Here is a suggestion:
For the media info check instead of it opening every time you do a re-scan for every item when you scan them it only opens on movies or series you haven't added yet instead of it applying it to every item in the media hoarder library. So it only applys the mediainfo to newly added series or movies not every video since they already exist in the library. So it only opens if you are adding a video for the first time or if a video is missing the media info.

@theMK2k
Copy link
Owner

theMK2k commented Jan 3, 2024

Hm, I can't confirm what you state here. So I tried to test this on my end:

Prerequisites:

  • Settings -> Log Level: TRACE

First test round:

  • Unaltered Media Library
  • Scan Media -> Quick Scan

image

During the whole scan no mediainfo entry can be seen in the logs:

image

Second test round:

  • Some media removed, library re-scanned (so the removed media is gone from the library) and re-added before the scan
  • Scan Media -> Quick Scan

Mediainfo is running on the added media files only - already known files are not touched by it.

image

@kolbdog3333
Copy link
Author

kolbdog3333 commented Jan 3, 2024

Weird it does it to me each time i do a quick scan not sure why. Since every quickscan it says applying mediainfo.

@theMK2k
Copy link
Owner

theMK2k commented Jan 3, 2024

OK, maybe some (hopefully not all) of your entries have scan errors:

image

In that case, Media Hoarder currently does not differentiate and tries to scrape IMDB data as well as run and apply mediainfo.

@kolbdog3333
Copy link
Author

Do i need to click anything when mediainfo opens or just click close maybe i am doing something wrong when it opens?

@theMK2k
Copy link
Owner

theMK2k commented Jan 3, 2024

Actually mediainfo should not visibly open at all. Are you using mediainfo-cli (which is the mediainfo command line application)?

@kolbdog3333
Copy link
Author

No i installed mediainfo where do i get the mediainfo-cli

@theMK2k
Copy link
Owner

theMK2k commented Jan 3, 2024

The Settings page in Media Hoarder should provide a link to the downloads section of mediainfo (and mediainfo-cli).

@theMK2k
Copy link
Owner

theMK2k commented Jan 3, 2024

Also: the Windows version of Media Hoarder ships mediainfo-cli as well.

@kolbdog3333
Copy link
Author

Okay thanks i tjhink i installed the Mediainfo instead of using the cli by mistake its a lot faster now

@theMK2k
Copy link
Owner

theMK2k commented Jan 3, 2024

Let's keep this open, we can optimize Media Hoarder here by actually analyzing the scan errors and not run mediainfo-cli on media which already successfully ran it before in quick scan mode.

@theMK2k theMK2k reopened this Jan 3, 2024
@theMK2k theMK2k removed this from the Road to Series Release (v1.4.0) milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants