Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude fullscreen applications or application blacklist #113

Open
ponpat opened this issue Jan 30, 2025 · 10 comments
Open

Exclude fullscreen applications or application blacklist #113

ponpat opened this issue Jan 30, 2025 · 10 comments
Labels
enhancement New feature or request

Comments

@ponpat
Copy link

ponpat commented Jan 30, 2025

Using User Story Format:
As a gamer I want an option that disables WritingTools during gaming so that it will not show up by accidentally hitting the shortcut and ruining my gaming experience.

Proposed solutions:
I see multiple approaches for this that would be better than what we have now, but maybe there are more and better ones:

  1. Being able to pause the app from the tray icon instead of closing it
  2. An option to automatically disable the shortcut in fullscreen apps.
  3. A blacklist for programs to deactivate the shortcut while in focus.
@momokrono momokrono added the enhancement New feature or request label Jan 30, 2025
@momokrono
Copy link
Collaborator

Hi,
thank you for the suggestion.

This is a valid issue, but I don't think disabling the app when another is in full-screen is a good approach: I code for most of my day, I usually keep my IDE in full-screen but I'd like the app to work.

However, 1. and 3. are valid points: I don't think it would be too much of an issue for the user to remember to "freeze" the app to later "unfreeze" it, and I could quickly implement it. 3. would be even "better" but in this case the user should input manually the name of the app into a list of blacklisted applications, and for less tech-savvy people could be bothersome.

@theJayTea what do you think?

@theJayTea
Copy link
Owner

theJayTea commented Jan 30, 2025

Hello!

This would be nice to implement. Someone had also previously requested this in #81.

I think freezing/pausing would be the best approach, as almost no gamer is going to enter every one of their huge list of games into a blacklist.

Plus, pausing would be nearly trivial to implement (and we can have Pause/Resume options in the Writing Tools right-click menu).

On the other hand, it would be more challenging to find an API that gives us the active window's program name on both Windows and Linux (getting window title wouldn't work as the title often changes based on the file open), and in addition, if the user has to find and enter the exact executable name, it wouldn't be very intuitive as mentioned.

@momokrono , thank you for offering to implement the freeze/pause! :D That'd be great (and if you're busy, I could also work on it in the future).

@momokrono
Copy link
Collaborator

@theJayTea Done, just pushed to dev

@theJayTea
Copy link
Owner

Awesome, thank you @momokrono ! In the next few days I’ll finish the GUI and we’ll have a pretty sweet update all thanks to you :D

@momokrono
Copy link
Collaborator

@theJayTea and I'll finally be listed as a contributor, yay! 😂

@theJayTea
Copy link
Owner

@momokrono we're going to shout you out toward the top of the README too :)

@momokrono
Copy link
Collaborator

@theJayTea ahahah it's not a problem, really. I'm not doing it for the recognition 😅 It's just funny that github only cares about commits to main when deciding who is and who isn't a contributor.

@ponpat
Copy link
Author

ponpat commented Feb 5, 2025

Oh, very cool to see you handled it this quickly and smoothly. While not my personal preference as a solution I think it solves the issue well enough to not be in a place to complain. I mean I even brought this possibility up :D You got my thumbs up for that :) Can't wait to not have my game randomly minimize to try because I hit ctrl and space together by accident in a hectic situation :D (Except if I forget to pause the program)

@theJayTea
Copy link
Owner

@momokrono GitHub is funny indeed here haha. I wish they were more holistic.

PS: I've been insanely busy these last days (and will be until ~tomorrow), so I’ll work on the GUI and we'll push the update by (hopefully before) this weekend :D

Thank you so, so much again!

@theJayTea
Copy link
Owner

theJayTea commented Feb 5, 2025

@ponpat , in addition, might I suggest remapping the shortcut to something like “ctrl+j” or “ctrl+`”? This way, even if you forget to pause it, you’re much less likely to hit it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants