Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core rules compendium with conditions, etc. #89

Open
1 task done
stanavdb opened this issue Oct 22, 2024 · 5 comments
Open
1 task done

Add core rules compendium with conditions, etc. #89

stanavdb opened this issue Oct 22, 2024 · 5 comments
Labels
compendium data SRD Content to be added into compendiums Enhancement Improvements not directly related to features/bugs feature request New feature good first issue Good for newcomers rule/mechanic ux User experience related issue
Milestone

Comments

@stanavdb
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently it's unclear what conditions do and the system provides no way to look this up.

Describe the solution you'd like
A rules compendium that contains things like conditions.

Describe alternatives you've considered

Version
0.1.0

Checklist:

  • I have searched the existing issues to ensure this feature has not already been requested.
@stanavdb stanavdb added the feature request New feature label Oct 22, 2024
@tbytnar
Copy link
Contributor

tbytnar commented Nov 2, 2024

@stanavdb does ./scripts/pack.js work for you? It runs and says that it Packs entries, but I dont actually see the content made in the compendiums. For example, I see Roll Tables as a compendium, but it's empty.

@stanavdb
Copy link
Collaborator Author

stanavdb commented Nov 3, 2024

@stanavdb does ./scripts/pack.js work for you? It runs and says that it Packs entries, but I dont actually see the content made in the compendiums. For example, I see Roll Tables as a compendium, but it's empty.

Yeah the pack script works for me.

@tbytnar
Copy link
Contributor

tbytnar commented Nov 3, 2024

@stanavdb does ./scripts/pack.js work for you? It runs and says that it Packs entries, but I dont actually see the content made in the compendiums. For example, I see Roll Tables as a compendium, but it's empty.

Yeah the pack script works for me.

I think I figured out my issue. I had to delete the packs from the build folder before running the pack script in order to get it to update. Minor annoyance.

If you don't mind, I'm going to work on this one.

@tbytnar
Copy link
Contributor

tbytnar commented Nov 5, 2024

@stanavdb
Is this close to what you had in mind? NOTE: Still tinkering with the css.

image

@zithith
Copy link
Collaborator

zithith commented Nov 13, 2024

That looks great!
Did you make a draft PR for this? would help us keep track, hopefully stan can assign you the issue too.

My thoughts would be that we perhaps need separate entries for each condition, so that they can be linked in descriptions on other items? This could be done by having separate pages under the condition list I guess? But I don't know how that might break the journal display? Or we just have a separate compendium with specific Conditions and any other rules keywords as Items that just have the rules text in their descriptions as reminder text.

If we take the Item route, then later down the line we could have an issue where if a Condition Item is drag-dropped onto a character sheet it toggles on/increases the count of that codition on the actor.

@zithith zithith added good first issue Good for newcomers ux User experience related issue Enhancement Improvements not directly related to features/bugs compendium data SRD Content to be added into compendiums rule/mechanic labels Jan 13, 2025
@zithith zithith added this to the Release 1.0.0 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compendium data SRD Content to be added into compendiums Enhancement Improvements not directly related to features/bugs feature request New feature good first issue Good for newcomers rule/mechanic ux User experience related issue
Projects
None yet
Development

No branches or pull requests

3 participants