TM Comment Consolidation in Github/Gitlab #2131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup GitLab GraphQL client and replace one call
Gitlab comment consolidation
|
Thank you for contributing to tgstation-server! The CI Pipeline workflow requires repository secrets and will not run without approval. Maintainers can add the |
tgstation-server-ci
bot
added
size/XXL
CI Approval Required
This reverts commit 4bec6d1.
tgstation-server-ci
bot
added
CI Approval Required
tgstation-server-ci
bot
added
CI Approval Required
|
Repos I experimented on: Drulikar/cmss13#2 |
tgstation-server-ci
bot
added
CI Approval Required
Cyberboss
requested changes
Feb 17, 2025
| mergeRequest(iid: $number) { | ||
| iid | ||
| id | ||
| notes { |
There was a problem hiding this comment.
Noting that we likely need to paginate any connections we're querying in the future but I'll wait for someone to complain about it
...Tgstation.Server.Host.Utils.GitLab.GraphQL/Tgstation.Server.Host.Utils.GitLab.GraphQL.csproj
Show resolved
Hide resolved
| "devDependencies": { | ||
| "apollo": "^2.34.0" | ||
| }, | ||
| "packageManager": "[email protected]+sha1.ac34549e6aa8e7ead463a7407e1c7390f61a6610" |
There was a problem hiding this comment.
This is the wrong version but that's my fault I think. Reminder to myself to fix after merging
| query GetMergeRequests($project: ID!, $numbers: [String!]!) { | ||
| project(fullPath: $project) { | ||
| mergeRequests(iids: $numbers) { | ||
| nodes { |
There was a problem hiding this comment.
Pointing out another connection that needs paginating eventually
src/Tgstation.Server.Host.Utils.GitLab.GraphQL/GraphQLGitLabClientFactory.cs
Outdated
Show resolved
Hide resolved
src/Tgstation.Server.Host/Components/Deployment/Remote/GitHubRemoteDeploymentManager.cs
Outdated
Show resolved
Hide resolved
src/Tgstation.Server.Host/Components/Deployment/Remote/GitLabRemoteDeploymentManager.cs
Outdated
Show resolved
Hide resolved
src/Tgstation.Server.Host/Utils/GitHub/IAuthenticatedGitHubService.cs
Outdated
Show resolved
Hide resolved
Cyberboss
added
Feature
Co-authored-by: Jordan Dominion <[email protected]>
tgstation-server-ci
bot
added
CI Approval Required
tgstation-server-ci
bot
added
CI Approval Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🆑
Transitioned GitLab API to GraphQL due to incomplete implementation (namely for MR notes) in the abandoned API.
The option "Post comment when test merge is deployed" will now be consolidated into one message (until it approaches comment limit). In other words, rather than a new message each deployment, an existing message (if it exists) will be edited with a new line. The content of the message has also been altered.
/🆑
TGS creates a lot of noise currently on PRs, and this attempts to put it all in one message.
Github testing (I had to fix the timestamp and comment handling):
Gitlab testing (I had to fix the heading having line endings that differ):
