-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global panic hook + catch_unwind #120
Conversation
Drafted so I can make output path configurable |
Dumb question, this is entirely "safe" and "rust native"? IE - its not auxtools levels of process hooking or similar, its just normal stuff? |
I forgot to finish this oops Yes this is completely fine, |
I'm not sure if this should be failing "silently" like it is now since that is going to cause problems, but that is how it is implemented right now 😓 Going to update this so that we can get a better grasp of errors on tg |
@Mothblocks My suggestion is just make it up to the individual modules how to handle a panic unwind. My module currently returns the panic string directly, since it normally outputs JSON that is quite easy to test for. Obviously for something like file_read it's a bit more difficult, but for now I think it's better than crashing the entire game. |
Mostly implemented in #160, this is pretty abandoned these days. |
Fixes #118.
Will log to rustg_panic.log, though I'm not sure where that's going to end up being.