Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drive Stats dashboard has incorrect speed units on Max Speed #4357

Closed
1 task done
chicagoandy opened this issue Nov 5, 2024 · 1 comment
Closed
1 task done

Drive Stats dashboard has incorrect speed units on Max Speed #4357

chicagoandy opened this issue Nov 5, 2024 · 1 comment
Labels
closed:duplicate This issue or pull request already exists

Comments

@chicagoandy
Copy link

chicagoandy commented Nov 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

The Drive Stats Dashboard has a widget for Max Speed, which is nor correctly converting for mph vs KM/h

While I would love to brag about driving 161mph, but this is not correctly converting to local units (mph). Model Y doesn't go 161mph.

image

Teslamate has unit_of_length set to 'mi'

But DB values are stored in KM/h. The UI is not converting max_speed to mph.

Expected Behavior

UI would convert the km/h to mph before displaying the value.

Steps To Reproduce

No response

Relevant log output

s6-rc: info: service legacy-services successfully started
[16:52:16] INFO: Checking for Grafana folder: TeslaMate
[16:52:16] INFO: ... RESTORED statistics.json
[16:52:16] INFO: ... RESTORED charge-level.json
[16:52:16] INFO: ... RESTORED battery-health.json
[16:52:16] INFO: ... RESTORED states.json
[16:52:16] INFO: ... RESTORED mileage.json
[16:52:17] INFO: ... RESTORED updates.json
[16:52:17] INFO: ... RESTORED charges.json
[16:52:17] INFO: ... RESTORED locations.json
[16:52:17] INFO: ... RESTORED overview.json
[16:52:17] INFO: ... RESTORED timeline.json
[16:52:17] INFO: ... RESTORED visited.json
[16:52:17] INFO: ... RESTORED drives.json
[16:52:17] INFO: ... RESTORED projected-range.json
[16:52:17] INFO: ... RESTORED drive-stats.json
[16:52:17] INFO: ... RESTORED trip.json
[16:52:17] INFO: ... RESTORED efficiency.json
[16:52:17] INFO: ... RESTORED charging-stats.json
[16:52:17] INFO: ... RESTORED vampire-drain.json
[16:52:17] INFO: ... RESTORED drive-details.json
[16:52:17] INFO: ... RESTORED charge-details.json
[16:52:17] INFO: Finished Importing Grafana Dashboards
[16:52:17] INFO: Creating database 'teslamate' on 192.168.86.104
[16:52:17] INFO: Database teslamate already exists
[16:52:17] INFO: Starting TeslaMate...

Screenshots

image
image

Additional data

No response

Type of installation

Docker

Version

v1.3.0

@cwanja
Copy link
Collaborator

cwanja commented Nov 5, 2024

Duplicate of #4343 and fixed in #4338 which will be packaged and released.

@cwanja cwanja added the closed:duplicate This issue or pull request already exists label Nov 5, 2024
@JakobLichterfeld JakobLichterfeld closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed:duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants