CI: update upload-artifact action

[JakobLichterfeld]

Run output: https://github.com/teslamate-org/teslamate/actions/runs/8035109824

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

--> Update to upload-artifact@v4

Breaking changes --> see Migration Guide

[micves]

Think this is causing errors in:
https://github.com/teslamate-org/teslamate/actions/runs/8064800308/job/22029399915

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

Found something here that could explain it:
actions/upload-artifact#478

[JakobLichterfeld]

Thanks, GitHub Actions are hard to test locally (even if it is possible in most cases).
Will take a deeper look into the naming. I was aware of the breaking change and considered it as not relevant, as we use it differently.

[micves]

Thanks for looking into it. There are many small steps in CI at the moment, but at some point it's all going to be sorted out :)

[JakobLichterfeld]

fixed with 39ab647
Unfortunately not tested, as for security reasons changes in .githubfolder are excluded for our automatic ci

[micves]

It looks like it works on master, but still not on PRs :(
https://github.com/teslamate-org/teslamate/actions/runs/8082839912/job/22084555821

in the log it seems to ignore ${{ matrix.runs-on }}

2024-02-28T15:27:19.5466184Z ##[group]Run actions/upload-artifact@v4
2024-02-28T15:27:19.5466740Z with:
2024-02-28T15:27:19.5467093Z name: single-digest-

[JakobLichterfeld]

Test with #3702

[JakobLichterfeld]

As I needed to adopt the digest naming again and our security is working, new test with #3703

[JakobLichterfeld]

Good thing our security guards works perfectly. Bad thing: testing GitHub actions is now a pain.

[JakobLichterfeld]

Test with #3704

[JakobLichterfeld]

Ok test looks good for the upload now, the merging is still failing: https://github.com/teslamate-org/teslamate/actions/runs/8089110554/job/22104597849?pr=3485

[JakobLichterfeld]

new test for merging with #3705

[JakobLichterfeld]

Merging works as expected, as path is not supported anymore, the working directory needs to be set beforehand, so follow-up steps can use the downloaded artifacts directly

[JakobLichterfeld]

new test with #3706

[JakobLichterfeld]

Finally working with v4 action, https://github.com/teslamate-org/teslamate/actions/runs/8094659397?pr=3708

@micves fyi

[micves]

Thanks a lot, that looks like it was a rough one :|