Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get MentoV2 included in Swappa #122

Closed
2 tasks
bowd opened this issue Jan 27, 2023 · 0 comments · Fixed by terminal-fi/swappa#42
Closed
2 tasks

Get MentoV2 included in Swappa #122

bowd opened this issue Jan 27, 2023 · 0 comments · Fixed by terminal-fi/swappa#42
Assignees

Comments

@bowd
Copy link
Contributor

bowd commented Jan 27, 2023

Description
Swappa provides smart contracts and a javascript library that allows consumers to find and execute trades on CELO at the best price.

Swappa includes an interface ISwappaPair that provides an abstraction over a "connector" to a specific dex and exposes methods to get the expected output amount and execute a swap.

Swappa contains an existing contract PairMento that implements the ISwappaPair interface and enables the retrieval and swaps using Mento exchanges.

As Swappa is fully open source we can add a new contract, PairMentoV2, that implements the ISwappaPair interfaces and allows the swappa router to query and execute swaps against MentoV2.

TODO: @bayological
Look into how TS classes are used and determine how to create a new class MentoV2.ts that provides necessary functions. Maybe ask ZViad or DiWu about this, may be as simple as inheriting from Pair and implementing base functions.

Acceptance Criteria

  • A new contract PairMentoV2, that implements ISwappaPair is created and allows consumers to query the broker for prices and execute trades on behalf of the user
  • The new contract is deployed, with its address added to a new json file in tools/deployed
@bowd bowd added this to Engineering Jan 26, 2023
@bowd bowd converted this from a draft issue Jan 27, 2023
@bayological bayological moved this from 📏 Needs Refinement to ⚖ Ready to Estimate in Engineering Mar 2, 2023
@bowd bowd moved this from ⚖ Ready to Estimate to 📝 Backlog in Engineering Mar 2, 2023
@ninabarbakadze ninabarbakadze moved this from 📝 Backlog to 🏗 In Progress in Engineering Mar 8, 2023
@ninabarbakadze ninabarbakadze self-assigned this Mar 8, 2023
@ninabarbakadze ninabarbakadze moved this from 🏗 In Progress to 🔬Ready for Review in Engineering Mar 22, 2023
@ninabarbakadze ninabarbakadze moved this from 🔬Ready for Review to 👀 In Review in Engineering Apr 4, 2023
@bowd bowd moved this from 🧑‍💻 Code Review to 📥 Backlog in Engineering Jul 14, 2023
@bowd bowd closed this as completed Aug 1, 2023
@github-project-automation github-project-automation bot moved this from 📥 Backlog to ✅ Done in Engineering Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants