Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failfactor in IntegratorOptions not used and causing type problems #175

Open
kylebeggs opened this issue Jan 15, 2025 · 1 comment
Open
Labels
bug Something isn't working

Comments

@kylebeggs
Copy link
Collaborator

The failfactor field doesn't seem to be used and causes issues when trying to use solution types other than Float64. Either we can remove it, or create a type parameter of its own so it does not need to match.

failfactor::tType = 4.0

@termi-official
Copy link
Owner

termi-official commented Jan 16, 2025

We can comment it out for now (and same goes for other unused stuff).

For some context here, I am working on how to adjust the internal dispatches in OrdinaryDiffEqCore to make external integrators compatible with the solvers, so I just mirrored some parts, but ended up not using others right now, as I do not fulfill the complete interface yet. See SciML/SciMLBase.jl#896 for a starter.

@termi-official termi-official added the bug Something isn't working label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants