Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PROPPATCH HTTP method for custom properties of file and directory #51

Open
hci2 opened this issue Nov 8, 2022 · 2 comments

Comments

@hci2
Copy link

hci2 commented Nov 8, 2022

It would be nice to add support for PROPPATCH HTTP method to add custom properties to a directory or file.

The way to do this is described in that article for the custom property invoicenumber: https://mathiasconradt.medium.com/how-to-assign-custom-meta-data-to-your-documents-on-nextcloud-23356cf3f926

There is also a half-working (stale) Nextcloud App for that: https://apps.nextcloud.com/apps/customproperties

It would be possible to allow an extraProperties (https://github.com/tentwentyfour/nextcloud-link#webdav-extraproperties) parameter as optional (extraProperties?: FileDetailProperty[]) to the uploadFromStream, put, touchFolder or createFolderHierarchy methods of the client.

The equivalent "PROPFIND HTTP method is not essentially needed because a similar result can be achieved via getFolderFileDetails method and the extraProperties property.

What do you think about that extension?

@kwisatz
Copy link
Member

kwisatz commented Nov 18, 2022

Hi @hci2, thanks for your suggestion.

We don't see any reason why this extension shouldn't be added to nextcloud-link. Would this be something that you'd be able to hand in as a PR (seeing how you already checked out where the code-base has to be extended) ?

@hci2
Copy link
Author

hci2 commented Nov 21, 2022

Thank you for your quick reply and the offer for a PR. But my request was intended to be a feature request. I don't have the time to work on that.

Because of time reasons and this missing feature, we had to switch to this library (https://github.com/perry-mitchell/webdav-client#customrequest) for the current project, which also fully supports custom properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants