From f4178283988fb05ba1fa5f8f86fdc01cbdabd84d Mon Sep 17 00:00:00 2001 From: Sanja Djukic Date: Wed, 19 Feb 2025 15:34:04 +0000 Subject: [PATCH 1/3] storing system desc --- src/common/module_builder.cc | 1 + src/common/pjrt_implementation/client_instance.cc | 1 + 2 files changed, 2 insertions(+) diff --git a/src/common/module_builder.cc b/src/common/module_builder.cc index 55cb112f..a800d5e9 100644 --- a/src/common/module_builder.cc +++ b/src/common/module_builder.cc @@ -197,6 +197,7 @@ void ModuleBuilder::convertFromTTIRToTTNN( mlir::PassManager ttir_to_ttnn_pm(mlir_module.get()->getName()); mlir::tt::ttnn::TTIRToTTNNBackendPipelineOptions options; + options.systemDescPath = "system_desc.ttsys"; mlir::tt::ttnn::createTTIRToTTNNBackendPipeline(ttir_to_ttnn_pm, options); // Run the pass manager. diff --git a/src/common/pjrt_implementation/client_instance.cc b/src/common/pjrt_implementation/client_instance.cc index 003a7985..99624bb6 100644 --- a/src/common/pjrt_implementation/client_instance.cc +++ b/src/common/pjrt_implementation/client_instance.cc @@ -164,6 +164,7 @@ void ClientInstance::BindApi(PJRT_Api *api) { tt_pjrt_status ClientInstance::PopulateDevices() { DLOG_F(LOG_DEBUG, "ClientInstance::PopulateDevices"); auto [system_desc, chip_ids] = tt::runtime::getCurrentSystemDesc(); + system_desc.store("system_desc.ttsys"); int devices_count = chip_ids.size(); devices_.resize(devices_count); From e1cd7016425b26a7fb112fda3c021af52e5984b4 Mon Sep 17 00:00:00 2001 From: sdjukicTT Date: Fri, 21 Feb 2025 19:12:48 +0000 Subject: [PATCH 2/3] addressed comment --- src/common/module_builder.cc | 2 +- src/common/module_builder.h | 2 ++ src/common/pjrt_implementation/client_instance.cc | 3 ++- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/common/module_builder.cc b/src/common/module_builder.cc index a800d5e9..4490f74c 100644 --- a/src/common/module_builder.cc +++ b/src/common/module_builder.cc @@ -197,7 +197,7 @@ void ModuleBuilder::convertFromTTIRToTTNN( mlir::PassManager ttir_to_ttnn_pm(mlir_module.get()->getName()); mlir::tt::ttnn::TTIRToTTNNBackendPipelineOptions options; - options.systemDescPath = "system_desc.ttsys"; + options.systemDescPath = system_desc_path; mlir::tt::ttnn::createTTIRToTTNNBackendPipeline(ttir_to_ttnn_pm, options); // Run the pass manager. diff --git a/src/common/module_builder.h b/src/common/module_builder.h index 548cc321..27982750 100644 --- a/src/common/module_builder.h +++ b/src/common/module_builder.h @@ -40,6 +40,8 @@ class ModuleBuilder { // code. Currently hardcoded to one, as we only support one-chip execution. size_t getNumAddressableDevices() const { return 1; } + static constexpr char const *system_desc_path = "system_desc.ttsys"; + private: // Creates VHLO module from the input program code. mlir::OwningOpRef diff --git a/src/common/pjrt_implementation/client_instance.cc b/src/common/pjrt_implementation/client_instance.cc index 99624bb6..e5d79070 100644 --- a/src/common/pjrt_implementation/client_instance.cc +++ b/src/common/pjrt_implementation/client_instance.cc @@ -27,6 +27,7 @@ ClientInstance::ClientInstance(std::unique_ptr platform) } ClientInstance::~ClientInstance() { + std::remove(ModuleBuilder::system_desc_path); DLOG_F(LOG_DEBUG, "ClientInstance::~ClientInstance"); } @@ -164,7 +165,7 @@ void ClientInstance::BindApi(PJRT_Api *api) { tt_pjrt_status ClientInstance::PopulateDevices() { DLOG_F(LOG_DEBUG, "ClientInstance::PopulateDevices"); auto [system_desc, chip_ids] = tt::runtime::getCurrentSystemDesc(); - system_desc.store("system_desc.ttsys"); + system_desc.store(ModuleBuilder::system_desc_path); int devices_count = chip_ids.size(); devices_.resize(devices_count); From 7a73e96361218abe0e378c6463a127af0660b6c6 Mon Sep 17 00:00:00 2001 From: sdjukicTT Date: Mon, 24 Feb 2025 11:14:23 +0000 Subject: [PATCH 3/3] addressed comments --- src/common/module_builder.cc | 2 +- src/common/module_builder.h | 2 +- .../pjrt_implementation/client_instance.cc | 4 ++-- system_desc.ttsys | Bin 0 -> 1200 bytes 4 files changed, 4 insertions(+), 4 deletions(-) create mode 100644 system_desc.ttsys diff --git a/src/common/module_builder.cc b/src/common/module_builder.cc index 4490f74c..a1e4366c 100644 --- a/src/common/module_builder.cc +++ b/src/common/module_builder.cc @@ -197,7 +197,7 @@ void ModuleBuilder::convertFromTTIRToTTNN( mlir::PassManager ttir_to_ttnn_pm(mlir_module.get()->getName()); mlir::tt::ttnn::TTIRToTTNNBackendPipelineOptions options; - options.systemDescPath = system_desc_path; + options.systemDescPath = system_desc_path.data(); mlir::tt::ttnn::createTTIRToTTNNBackendPipeline(ttir_to_ttnn_pm, options); // Run the pass manager. diff --git a/src/common/module_builder.h b/src/common/module_builder.h index 27982750..4e9f7eff 100644 --- a/src/common/module_builder.h +++ b/src/common/module_builder.h @@ -40,7 +40,7 @@ class ModuleBuilder { // code. Currently hardcoded to one, as we only support one-chip execution. size_t getNumAddressableDevices() const { return 1; } - static constexpr char const *system_desc_path = "system_desc.ttsys"; + static constexpr std::string_view system_desc_path = "system_desc.ttsys"; private: // Creates VHLO module from the input program code. diff --git a/src/common/pjrt_implementation/client_instance.cc b/src/common/pjrt_implementation/client_instance.cc index e5d79070..a52c062a 100644 --- a/src/common/pjrt_implementation/client_instance.cc +++ b/src/common/pjrt_implementation/client_instance.cc @@ -27,8 +27,8 @@ ClientInstance::ClientInstance(std::unique_ptr platform) } ClientInstance::~ClientInstance() { - std::remove(ModuleBuilder::system_desc_path); DLOG_F(LOG_DEBUG, "ClientInstance::~ClientInstance"); + std::remove(ModuleBuilder::system_desc_path.data()); } PJRT_Error *ClientInstance::Initialize() { @@ -165,7 +165,7 @@ void ClientInstance::BindApi(PJRT_Api *api) { tt_pjrt_status ClientInstance::PopulateDevices() { DLOG_F(LOG_DEBUG, "ClientInstance::PopulateDevices"); auto [system_desc, chip_ids] = tt::runtime::getCurrentSystemDesc(); - system_desc.store(ModuleBuilder::system_desc_path); + system_desc.store(ModuleBuilder::system_desc_path.data()); int devices_count = chip_ids.size(); devices_.resize(devices_count); diff --git a/system_desc.ttsys b/system_desc.ttsys new file mode 100644 index 0000000000000000000000000000000000000000..0f9175576723b98f087e166f409b731ddcb48070 GIT binary patch literal 1200 zcmYk4y-osA5QS$E6cppXVq!sIK_Q7EC?+OSQkqC(Wp-IMF&eaxXkqC~*!ciHl!eb= z?fG`^BusMl%pLBzbLL*Y%VyhVHX7aB)~#V>tJ}INb=8R4f~jg&6|RLPVK#l3KD|z@ zr98=!em_mKc-%=(<2dWY$#JjK%d(U6^CX?bX`*^}a-pp{_dw@YLx+aeW<%jpI2H~C z`pQxsQQ&!^CQIhO!K1K7Tg{!)r8s9z{MJ9aJL|Te$L+`a>FiB?u5%v)IT&izhI}^Hv4=YzE#6%v)3635-kDdx7!K zdSBQO(81_n_QULl*-sQ+i=1y1(o$gFjKCXFDJZ`eQvO#2cTLm^(yT?Shz0`lIPgY} zH<+1VJi>T{@dz`MYhVX@a`Z5I7(I+0M(@2`13S=@qleMM=wbBk(R;ZDcAzIm52J_C z`)uyfd$|U7peIKUqo?L~<1@Nf@5x^FIna}%C-*z`yYU&_tM^31eg}Fm{}!z0?}qif JSJvoZ@DEt@H5>o{ literal 0 HcmV?d00001