Enable temporary shardy roudtrip import pass #279
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooseokTT
requested review from
ajakovljevicTT,
kmitrovicTT and
mrakitaTT
as code owners
|
This still needs further testing. I am just checking if it passes the pre-merge tests. |
|
||||||||||||||
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 78.09% 69.02% -9.07%
==========================================
Files 21 22 +1
Lines 986 1188 +202
==========================================
+ Hits 770 820 +50
- Misses 216 368 +152 ☔ View full report in Codecov by Sentry. |
wooseokTT
force-pushed
the
wooseok/shardy_roundtrip_pass
branch
from
07b387a to
3501fa3
Compare
|
Google engineer reported to me that this pass can be included in Shardy repo by the end of this week (hopefully), so I am holding this PR to leverage the pass instead of creating shardy_roundtrip_pass.cc in tt-xla repo. The code is ready but still need to wait for tt-mlir and shardy repo to incorporate the 'roundtrip' pipeline code. |
wooseokTT
force-pushed
the
wooseok/shardy_roundtrip_pass
branch
from
3501fa3 to
2c23189
Compare
wooseokTT
force-pushed
the
wooseok/shardy_roundtrip_pass
branch
from
2c23189 to
479f005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Current JAX/openXLA is not natively support Shardy and stablehlo for compilation is not with fully Shardy dialect but with some openXLA intermediate format.
What's changed
This patch is a temporary solution that allows the openXLA intermediate form to be converted to Shardy dialect. Once openXLA supports Shardy natively in near future, this pass can be removed.
Checklist