From ebb0f945ed8d3c05e043158978201ed6fab884ec Mon Sep 17 00:00:00 2001 From: pjanevski Date: Sun, 9 Feb 2025 01:05:46 +0000 Subject: [PATCH] Remove TTDevice mutex --- device/api/umd/device/tt_device/tt_device.h | 8 -------- device/tt_device/tt_device.cpp | 19 +------------------ 2 files changed, 1 insertion(+), 26 deletions(-) diff --git a/device/api/umd/device/tt_device/tt_device.h b/device/api/umd/device/tt_device/tt_device.h index ac648ad3..f7c699c6 100644 --- a/device/api/umd/device/tt_device/tt_device.h +++ b/device/api/umd/device/tt_device/tt_device.h @@ -28,10 +28,6 @@ struct dynamic_tlb { uint64_t remaining_size; // Bytes remaining between bar_offset and end of the TLB. }; -namespace boost::interprocess { -class named_mutex; -} - namespace tt::umd { class TLBManager; @@ -151,10 +147,6 @@ class TTDevice { void memcpy_to_device(void *dest, const void *src, std::size_t num_bytes); void memcpy_from_device(void *dest, const void *src, std::size_t num_bytes); - void create_read_write_mutex(); - - std::shared_ptr read_write_mutex = nullptr; - ChipInfo chip_info; }; } // namespace tt::umd diff --git a/device/tt_device/tt_device.cpp b/device/tt_device/tt_device.cpp index 660186b1..870fdb13 100644 --- a/device/tt_device/tt_device.cpp +++ b/device/tt_device/tt_device.cpp @@ -3,18 +3,12 @@ // SPDX-License-Identifier: Apache-2.0 #include "umd/device/tt_device/tt_device.h" -#include -#include -#include - #include "logger.hpp" #include "umd/device/driver_atomics.h" #include "umd/device/tt_device/blackhole_tt_device.h" #include "umd/device/tt_device/grayskull_tt_device.h" #include "umd/device/tt_device/wormhole_tt_device.h" -using namespace boost::interprocess; - namespace tt::umd { TTDevice::TTDevice( @@ -22,9 +16,7 @@ TTDevice::TTDevice( pci_device_(std::move(pci_device)), architecture_impl_(std::move(architecture_impl)), tlb_manager_(std::make_unique(this)), - arch(architecture_impl_->get_architecture()) { - create_read_write_mutex(); -} + arch(architecture_impl_->get_architecture()) {} /* static */ std::unique_ptr TTDevice::create(int pci_device_number) { auto pci_device = std::make_unique(pci_device_number); @@ -216,7 +208,6 @@ void TTDevice::read_block(uint64_t byte_addr, uint64_t num_bytes, uint8_t *buffe } void TTDevice::read_from_device(void *mem_ptr, tt_xy_pair core, uint64_t addr, uint32_t size) { - const scoped_lock lock(*read_write_mutex); uint8_t *buffer_addr = static_cast(mem_ptr); const uint32_t tlb_index = get_architecture_implementation()->get_small_read_write_tlb(); while (size > 0) { @@ -231,10 +222,8 @@ void TTDevice::read_from_device(void *mem_ptr, tt_xy_pair core, uint64_t addr, u } void TTDevice::write_to_device(void *mem_ptr, tt_xy_pair core, uint64_t addr, uint32_t size) { - const scoped_lock lock(*read_write_mutex); uint8_t *buffer_addr = static_cast(mem_ptr); const uint32_t tlb_index = get_architecture_implementation()->get_small_read_write_tlb(); - // const scoped_lock lock(*get_mutex(fallback_tlb, target.chip)); while (size > 0) { auto [mapped_address, tlb_size] = set_dynamic_tlb(tlb_index, core, addr, tt::umd::tlb_data::Strict); @@ -352,10 +341,4 @@ void TTDevice::configure_iatu_region(size_t region, uint64_t base, uint64_t targ throw std::runtime_error("configure_iatu_region is not implemented for this device"); } -void TTDevice::create_read_write_mutex() { - permissions unrestricted_permissions; - unrestricted_permissions.set_unrestricted(); - read_write_mutex = std::make_shared(open_or_create, "read_write_mutex", unrestricted_permissions); -} - } // namespace tt::umd