Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of / make optional: flatbuffers #522

Open
alex-s168 opened this issue Feb 7, 2025 · 1 comment
Open

get rid of / make optional: flatbuffers #522

alex-s168 opened this issue Feb 7, 2025 · 1 comment
Labels
enhancement New feature or request repo health Code design, code readability, linting, file restructuring, etc.

Comments

@alex-s168
Copy link

Flatbuffers is a heavy dependency and takes up a major amount of build time.
This is not important, but it would be more convenient if flatbuffers was optional or removed completely
It seems like it is only used in tt_simulation_device.fbs

@pjanevskiTT pjanevskiTT added the repo health Code design, code readability, linting, file restructuring, etc. label Feb 15, 2025
@milank94 milank94 added the enhancement New feature or request label Feb 18, 2025
@pjanevskiTT
Copy link
Contributor

@alex-s168 thanks for opening this issue

I also think this just makes the header file with same structs as in flatbuffer, looks like it can be moved to .h file.

Have you measured the exact time of the build time difference when we use .fbs and when this is moved to the .h file? Anyway, It would be nice to remove it no matter how big the build time difference is.

If you want to work on it, you can assign it yourself or I can assign it to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request repo health Code design, code readability, linting, file restructuring, etc.
Projects
None yet
Development

No branches or pull requests

3 participants