Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global functions #105

Closed
broskoTT opened this issue Oct 3, 2024 · 1 comment
Closed

Remove global functions #105

broskoTT opened this issue Oct 3, 2024 · 1 comment
Labels
api redesign Related to the ongoing push for redesigning UMDs api

Comments

@broskoTT
Copy link
Contributor

broskoTT commented Oct 3, 2024

There are many functions which accept TTDevice/PCIDevice as a first argument -> These should be moved as private members of these classes.
There are also some functions which should be private members of tt_SiliconDriver.
There are also some functions which can go to a new file "system_utils.h" and be implemented as global there, so that its clear they aren't tied to any specific class.

Revisit all global functions.
@broskoTT broskoTT added the api redesign Related to the ongoing push for redesigning UMDs api label Oct 3, 2024
@broskoTT
Copy link
Contributor Author

broskoTT commented Nov 6, 2024 •
edited
Loading

Worked on this in several PRs such as #253 #149 #144 and #155, but most of what was captured by this issue has been fixed since

@broskoTT broskoTT closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api redesign Related to the ongoing push for redesigning UMDs api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@broskoTT