Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2005: Added representation of reduce scatter in ttir and ttnn dialect #2127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#2005: Added representation of reduce scatter in ttir and ttnn dialect #2127

wants to merge 1 commit into from
+869 −28

Conversation

tapspatel
Copy link
Collaborator

@tapspatel tapspatel commented Feb 6, 2025 •
edited
Loading

Implemented conversion patterns between dialects and flatbuffer. Added tests cases for all valid multichip mesh configurations

@tapspatel tapspatel self-assigned this Feb 6, 2025
@tapspatel tapspatel linked an issue Feb 6, 2025 that may be closed by this pull request
Add shlo to ttir pass for reduce_scatter #2005
Open
@tapspatel
Copy link
Collaborator Author

tapspatel commented Feb 6, 2025 •
edited
Loading

This PR is blocked by metal mesh reshape bug tenstorrent/tt-metal#17646 (fixed)

@tapspatel
Copy link
Collaborator Author

tapspatel commented Feb 20, 2025 •
edited
Loading

this PR is blocked by: #2215

@tapspatel tapspatel force-pushed the tpatel/issue-2005 branch 3 times, most recently from 50095f5 to ff9d6bb Compare February 21, 2025 01:25
@tapspatel tapspatel marked this pull request as ready for review February 21, 2025 01:26
@tapspatel tapspatel mentioned this pull request Feb 21, 2025
Open
jnie-TT
jnie-TT approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@jnie-TT jnie-TT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime changes look good (Actually look identical to #2215 :))

@tapspatel tapspatel marked this pull request as draft February 21, 2025 20:53
@tapspatel tapspatel marked this pull request as ready for review February 27, 2025 21:56
@tapspatel tapspatel changed the title #2005: Added representation of reduce scatter in ttir and ttnn dialect. Implemented conversion patterns between dialects and flatbuffer. Added tests cases for all valid multichip mesh configurations #2005: Added representation of reduce scatter in ttir and ttnn dialect Feb 27, 2025
@tapspatel tapspatel mentioned this pull request Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnie-TT jnie-TT jnie-TT approved these changes

@kmabeeTT kmabeeTT Awaiting requested review from kmabeeTT

@AleksKnezevic AleksKnezevic Awaiting requested review from AleksKnezevic

@pilkicTT pilkicTT Awaiting requested review from pilkicTT

@svuckovicTT svuckovicTT Awaiting requested review from svuckovicTT svuckovicTT is a code owner

@mtopalovicTT mtopalovicTT Awaiting requested review from mtopalovicTT mtopalovicTT is a code owner

@jserbedzijaTT jserbedzijaTT Awaiting requested review from jserbedzijaTT jserbedzijaTT is a code owner

@azecevicTT azecevicTT Awaiting requested review from azecevicTT azecevicTT is a code owner

@nsmithtt nsmithtt Awaiting requested review from nsmithtt nsmithtt is a code owner

@mrakitaTT mrakitaTT Awaiting requested review from mrakitaTT mrakitaTT is a code owner

@sdjordjevicTT sdjordjevicTT Awaiting requested review from sdjordjevicTT sdjordjevicTT is a code owner

@wooseokTT wooseokTT Awaiting requested review from wooseokTT

At least 1 approving review is required to merge this pull request.

Assignees

@tapspatel tapspatel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add shlo to ttir pass for reduce_scatter
3 participants
@tapspatel @sdjordjevicTT @jnie-TT