From 471ca8a2ac906a4596425df32b001121a76f886f Mon Sep 17 00:00:00 2001 From: blozano-tt Date: Thu, 7 Nov 2024 23:32:03 +0000 Subject: [PATCH 1/6] #0: Allow Users to provide extra tag for T3K choose your own pipeline --- .github/workflows/pipeline-select-t3k.yaml | 16 ++++++++++++++++ .github/workflows/t3000-demo-tests-impl.yaml | 7 ++++++- .github/workflows/t3000-frequent-tests-impl.yaml | 7 ++++++- .../workflows/t3000-model-perf-tests-impl.yaml | 7 ++++++- .github/workflows/t3000-nightly-tests-impl.yaml | 7 ++++++- .github/workflows/t3000-profiler-tests-impl.yaml | 7 ++++++- .github/workflows/t3000-unit-tests-impl.yaml | 7 ++++++- 7 files changed, 52 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pipeline-select-t3k.yaml b/.github/workflows/pipeline-select-t3k.yaml index 3df726bdd6e..df87dd7c696 100644 --- a/.github/workflows/pipeline-select-t3k.yaml +++ b/.github/workflows/pipeline-select-t3k.yaml @@ -12,6 +12,10 @@ on: - RelWithDebInfo - CI default: "Release" + extra-tag: + required: false + type: string + default: "" build-with-tracy: required: false type: boolean @@ -54,29 +58,41 @@ jobs: needs: build-artifact secrets: inherit uses: ./.github/workflows/t3000-unit-tests-impl.yaml + with: + extra-tag: ${{ inputs.extra-tag }} if: ${{ inputs.t3000-unit }} t3000-demo-tests: needs: build-artifact secrets: inherit uses: ./.github/workflows/t3000-demo-tests-impl.yaml + with: + extra-tag: ${{ inputs.extra-tag }} if: ${{ inputs.t3000-demo }} t3000-frequent-tests: needs: build-artifact secrets: inherit uses: ./.github/workflows/t3000-frequent-tests-impl.yaml + with: + extra-tag: ${{ inputs.extra-tag }} if: ${{ inputs.t3000-frequent }} t3000-nightly-tests: needs: build-artifact secrets: inherit uses: ./.github/workflows/t3000-nightly-tests-impl.yaml + with: + extra-tag: ${{ inputs.extra-tag }} if: ${{ inputs.t3000-nightly }} t3000-model-perf-tests: needs: build-artifact secrets: inherit uses: ./.github/workflows/t3000-model-perf-tests-impl.yaml + with: + extra-tag: ${{ inputs.extra-tag }} if: ${{ inputs.t3000-model-perf }} t3000-profiler-tests: needs: build-artifact secrets: inherit uses: ./.github/workflows/t3000-profiler-tests-impl.yaml + with: + extra-tag: ${{ inputs.extra-tag }} if: ${{ inputs.t3000-profiler }} diff --git a/.github/workflows/t3000-demo-tests-impl.yaml b/.github/workflows/t3000-demo-tests-impl.yaml index 8c3d98815a3..2b9b2571f41 100644 --- a/.github/workflows/t3000-demo-tests-impl.yaml +++ b/.github/workflows/t3000-demo-tests-impl.yaml @@ -2,6 +2,11 @@ name: "[internal] T3000 demo tests impl" on: workflow_call: + inputs: + extra-tag: + required: false + type: string + default: "" jobs: t3000-demo-tests: @@ -23,7 +28,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf"] + runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}] steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Enable performance mode diff --git a/.github/workflows/t3000-frequent-tests-impl.yaml b/.github/workflows/t3000-frequent-tests-impl.yaml index f770b1db457..9b6a02c074c 100644 --- a/.github/workflows/t3000-frequent-tests-impl.yaml +++ b/.github/workflows/t3000-frequent-tests-impl.yaml @@ -2,6 +2,11 @@ name: "[internal] T3000 frequent tests impl" on: workflow_call: + inputs: + extra-tag: + required: false + type: string + default: "" jobs: t3000-frequent-tests: @@ -27,7 +32,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional"] + runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}] steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - uses: ./.github/actions/ensure-active-weka-mount diff --git a/.github/workflows/t3000-model-perf-tests-impl.yaml b/.github/workflows/t3000-model-perf-tests-impl.yaml index 1787bd5c2e9..a7abe018c16 100644 --- a/.github/workflows/t3000-model-perf-tests-impl.yaml +++ b/.github/workflows/t3000-model-perf-tests-impl.yaml @@ -2,6 +2,11 @@ name: "[internal] T3000 model perf tests impl" on: workflow_call: + inputs: + extra-tag: + required: false + type: string + default: "" jobs: @@ -25,7 +30,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf"] + runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf", ${{ inputs.extra-tag }}] steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Enable performance mode diff --git a/.github/workflows/t3000-nightly-tests-impl.yaml b/.github/workflows/t3000-nightly-tests-impl.yaml index 009e6549d19..3c41fa99660 100644 --- a/.github/workflows/t3000-nightly-tests-impl.yaml +++ b/.github/workflows/t3000-nightly-tests-impl.yaml @@ -2,6 +2,11 @@ name: "[internal] T3000 nightly tests impl" on: workflow_call: + inputs: + extra-tag: + required: false + type: string + default: "" jobs: t3000-nightly-tests: @@ -18,7 +23,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional"] + runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}] steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Set up dynamic env vars for build diff --git a/.github/workflows/t3000-profiler-tests-impl.yaml b/.github/workflows/t3000-profiler-tests-impl.yaml index ebd4940bb68..da570070ee4 100644 --- a/.github/workflows/t3000-profiler-tests-impl.yaml +++ b/.github/workflows/t3000-profiler-tests-impl.yaml @@ -2,6 +2,11 @@ name: "[internal] T3000 profiler tests impl" on: workflow_call: + inputs: + extra-tag: + required: false + type: string + default: "" jobs: t3000-profiler-tests: @@ -12,7 +17,7 @@ jobs: { name: "T3000 profiler tests", arch: wormhole_b0, - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf"], + runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf", ${{ inputs.extra-tag }}], cmd: './tests/scripts/run_profiler_regressions.sh' }, ] diff --git a/.github/workflows/t3000-unit-tests-impl.yaml b/.github/workflows/t3000-unit-tests-impl.yaml index 0fce1a2b5e5..c96df64b23d 100644 --- a/.github/workflows/t3000-unit-tests-impl.yaml +++ b/.github/workflows/t3000-unit-tests-impl.yaml @@ -2,6 +2,11 @@ name: "[internal] T3000 unit tests impl" on: workflow_call: + inputs: + extra-tag: + required: false + type: string + default: "" jobs: t3000-unit-tests: @@ -28,7 +33,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional"] + runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}] steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Set up dynamic env vars for build From 596911ce48bbfc361c5b58d7562196bccec83206 Mon Sep 17 00:00:00 2001 From: Bryan Wilder Field Lozano Date: Thu, 7 Nov 2024 15:46:24 -0800 Subject: [PATCH 2/6] #0: Apply suggestions from code review --- .github/workflows/t3000-demo-tests-impl.yaml | 2 +- .github/workflows/t3000-frequent-tests-impl.yaml | 2 +- .github/workflows/t3000-model-perf-tests-impl.yaml | 2 +- .github/workflows/t3000-nightly-tests-impl.yaml | 2 +- .github/workflows/t3000-profiler-tests-impl.yaml | 2 +- .github/workflows/t3000-unit-tests-impl.yaml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/t3000-demo-tests-impl.yaml b/.github/workflows/t3000-demo-tests-impl.yaml index 2b9b2571f41..586de53a90b 100644 --- a/.github/workflows/t3000-demo-tests-impl.yaml +++ b/.github/workflows/t3000-demo-tests-impl.yaml @@ -28,7 +28,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}] + runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Enable performance mode diff --git a/.github/workflows/t3000-frequent-tests-impl.yaml b/.github/workflows/t3000-frequent-tests-impl.yaml index 9b6a02c074c..8db2738f7c5 100644 --- a/.github/workflows/t3000-frequent-tests-impl.yaml +++ b/.github/workflows/t3000-frequent-tests-impl.yaml @@ -32,7 +32,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}] + runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - uses: ./.github/actions/ensure-active-weka-mount diff --git a/.github/workflows/t3000-model-perf-tests-impl.yaml b/.github/workflows/t3000-model-perf-tests-impl.yaml index a7abe018c16..47d0a31f726 100644 --- a/.github/workflows/t3000-model-perf-tests-impl.yaml +++ b/.github/workflows/t3000-model-perf-tests-impl.yaml @@ -30,7 +30,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf", ${{ inputs.extra-tag }}] + runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Enable performance mode diff --git a/.github/workflows/t3000-nightly-tests-impl.yaml b/.github/workflows/t3000-nightly-tests-impl.yaml index 3c41fa99660..1f3e67fdc25 100644 --- a/.github/workflows/t3000-nightly-tests-impl.yaml +++ b/.github/workflows/t3000-nightly-tests-impl.yaml @@ -23,7 +23,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}] + runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Set up dynamic env vars for build diff --git a/.github/workflows/t3000-profiler-tests-impl.yaml b/.github/workflows/t3000-profiler-tests-impl.yaml index da570070ee4..21dd55b1555 100644 --- a/.github/workflows/t3000-profiler-tests-impl.yaml +++ b/.github/workflows/t3000-profiler-tests-impl.yaml @@ -17,7 +17,7 @@ jobs: { name: "T3000 profiler tests", arch: wormhole_b0, - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf", ${{ inputs.extra-tag }}], + runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} cmd: './tests/scripts/run_profiler_regressions.sh' }, ] diff --git a/.github/workflows/t3000-unit-tests-impl.yaml b/.github/workflows/t3000-unit-tests-impl.yaml index c96df64b23d..d5106f7db36 100644 --- a/.github/workflows/t3000-unit-tests-impl.yaml +++ b/.github/workflows/t3000-unit-tests-impl.yaml @@ -33,7 +33,7 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}] + runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Set up dynamic env vars for build From fd580bd8f8ce1d9e40ed12106df82b1837710277 Mon Sep 17 00:00:00 2001 From: Bryan Wilder Field Lozano Date: Thu, 7 Nov 2024 15:56:14 -0800 Subject: [PATCH 3/6] Update .github/workflows/t3000-demo-tests-impl.yaml --- .github/workflows/t3000-demo-tests-impl.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/t3000-demo-tests-impl.yaml b/.github/workflows/t3000-demo-tests-impl.yaml index 586de53a90b..35343d17cb2 100644 --- a/.github/workflows/t3000-demo-tests-impl.yaml +++ b/.github/workflows/t3000-demo-tests-impl.yaml @@ -28,7 +28,12 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} + runs-on: + - arch-wormhole_b0 + - config-t3000 + - in-service + - pipeline-functional + - ${{ inputs.extra-tag }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Enable performance mode From 91dccfc6b7048e10149e549fbc56cf1443a4b583 Mon Sep 17 00:00:00 2001 From: Bryan Wilder Field Lozano Date: Thu, 7 Nov 2024 16:10:18 -0800 Subject: [PATCH 4/6] #0: Apply suggestions from code review --- .github/workflows/pipeline-select-t3k.yaml | 4 ++-- .github/workflows/t3000-demo-tests-impl.yaml | 7 +++---- .github/workflows/t3000-frequent-tests-impl.yaml | 4 ++-- .github/workflows/t3000-model-perf-tests-impl.yaml | 10 +++++++--- .github/workflows/t3000-profiler-tests-impl.yaml | 6 +++++- .github/workflows/t3000-unit-tests-impl.yaml | 10 +++++++--- 6 files changed, 26 insertions(+), 15 deletions(-) diff --git a/.github/workflows/pipeline-select-t3k.yaml b/.github/workflows/pipeline-select-t3k.yaml index df87dd7c696..d602c81a73e 100644 --- a/.github/workflows/pipeline-select-t3k.yaml +++ b/.github/workflows/pipeline-select-t3k.yaml @@ -13,9 +13,9 @@ on: - CI default: "Release" extra-tag: - required: false + required: true type: string - default: "" + default: "in-service" build-with-tracy: required: false type: boolean diff --git a/.github/workflows/t3000-demo-tests-impl.yaml b/.github/workflows/t3000-demo-tests-impl.yaml index 35343d17cb2..a67f635b32f 100644 --- a/.github/workflows/t3000-demo-tests-impl.yaml +++ b/.github/workflows/t3000-demo-tests-impl.yaml @@ -4,9 +4,9 @@ on: workflow_call: inputs: extra-tag: - required: false + required: true type: string - default: "" + default: "in-service" jobs: t3000-demo-tests: @@ -31,8 +31,7 @@ jobs: runs-on: - arch-wormhole_b0 - config-t3000 - - in-service - - pipeline-functional + - pipeline-perf - ${{ inputs.extra-tag }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 diff --git a/.github/workflows/t3000-frequent-tests-impl.yaml b/.github/workflows/t3000-frequent-tests-impl.yaml index 8db2738f7c5..fe9a01f6239 100644 --- a/.github/workflows/t3000-frequent-tests-impl.yaml +++ b/.github/workflows/t3000-frequent-tests-impl.yaml @@ -4,9 +4,9 @@ on: workflow_call: inputs: extra-tag: - required: false + required: true type: string - default: "" + default: "in-service" jobs: t3000-frequent-tests: diff --git a/.github/workflows/t3000-model-perf-tests-impl.yaml b/.github/workflows/t3000-model-perf-tests-impl.yaml index 47d0a31f726..9cfeb3525ee 100644 --- a/.github/workflows/t3000-model-perf-tests-impl.yaml +++ b/.github/workflows/t3000-model-perf-tests-impl.yaml @@ -4,9 +4,9 @@ on: workflow_call: inputs: extra-tag: - required: false + required: true type: string - default: "" + default: "in-service" jobs: @@ -30,7 +30,11 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} + runs-on: + - arch-wormhole_b0 + - config-t3000 + - pipeline-perf + - ${{ inputs.extra-tag }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Enable performance mode diff --git a/.github/workflows/t3000-profiler-tests-impl.yaml b/.github/workflows/t3000-profiler-tests-impl.yaml index 21dd55b1555..dae0e20b79e 100644 --- a/.github/workflows/t3000-profiler-tests-impl.yaml +++ b/.github/workflows/t3000-profiler-tests-impl.yaml @@ -17,7 +17,11 @@ jobs: { name: "T3000 profiler tests", arch: wormhole_b0, - runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} + runs-on: + - arch-wormhole_b0 + - config-t3000 + - pipeline-perf + - ${{ inputs.extra-tag }} cmd: './tests/scripts/run_profiler_regressions.sh' }, ] diff --git a/.github/workflows/t3000-unit-tests-impl.yaml b/.github/workflows/t3000-unit-tests-impl.yaml index d5106f7db36..b1706331152 100644 --- a/.github/workflows/t3000-unit-tests-impl.yaml +++ b/.github/workflows/t3000-unit-tests-impl.yaml @@ -4,9 +4,9 @@ on: workflow_call: inputs: extra-tag: - required: false + required: true type: string - default: "" + default: "in-service" jobs: t3000-unit-tests: @@ -33,7 +33,11 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} + runs-on: + - arch-wormhole_b0 + - config-t3000 + - pipeline-functional + - ${{ inputs.extra-tag }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Set up dynamic env vars for build From 3d536aef5fee5b1875bd8569b1e13d67240bbf85 Mon Sep 17 00:00:00 2001 From: Bryan Wilder Field Lozano Date: Thu, 7 Nov 2024 16:15:53 -0800 Subject: [PATCH 5/6] #0: Apply suggestions from code review --- .github/workflows/t3000-frequent-tests-impl.yaml | 6 +++++- .github/workflows/t3000-nightly-tests-impl.yaml | 10 +++++++--- .github/workflows/t3000-profiler-tests-impl.yaml | 4 ++-- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/.github/workflows/t3000-frequent-tests-impl.yaml b/.github/workflows/t3000-frequent-tests-impl.yaml index fe9a01f6239..2eebf0b7ef3 100644 --- a/.github/workflows/t3000-frequent-tests-impl.yaml +++ b/.github/workflows/t3000-frequent-tests-impl.yaml @@ -32,7 +32,11 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} + runs-on: + - arch-wormhole_b0 + - config-t3000 + - pipeline-functional + - ${{ inputs.extra-tag }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - uses: ./.github/actions/ensure-active-weka-mount diff --git a/.github/workflows/t3000-nightly-tests-impl.yaml b/.github/workflows/t3000-nightly-tests-impl.yaml index 1f3e67fdc25..422d1bc4350 100644 --- a/.github/workflows/t3000-nightly-tests-impl.yaml +++ b/.github/workflows/t3000-nightly-tests-impl.yaml @@ -4,9 +4,9 @@ on: workflow_call: inputs: extra-tag: - required: false + required: true type: string - default: "" + default: "in-service" jobs: t3000-nightly-tests: @@ -23,7 +23,11 @@ jobs: ARCH_NAME: ${{ matrix.test-group.arch }} LOGURU_LEVEL: INFO LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib - runs-on: ${{ toJson([ "arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional" ] + (inputs.extra-tag != '' && inputs.extra-tag != null ? [inputs.extra-tag] : [])) }} + runs-on: + - arch-wormhole_b0 + - config-t3000 + - pipeline-functional + - ${{ inputs.extra-tag }} steps: - uses: tenstorrent-metal/metal-workflows/.github/actions/checkout-with-submodule-lfs@v2.0.0 - name: Set up dynamic env vars for build diff --git a/.github/workflows/t3000-profiler-tests-impl.yaml b/.github/workflows/t3000-profiler-tests-impl.yaml index dae0e20b79e..ba5330b0109 100644 --- a/.github/workflows/t3000-profiler-tests-impl.yaml +++ b/.github/workflows/t3000-profiler-tests-impl.yaml @@ -4,9 +4,9 @@ on: workflow_call: inputs: extra-tag: - required: false + required: true type: string - default: "" + default: "in-service" jobs: t3000-profiler-tests: From 884e40096066bd88daa62b453275e0418c4d0901 Mon Sep 17 00:00:00 2001 From: blozano-tt Date: Fri, 8 Nov 2024 00:31:25 +0000 Subject: [PATCH 6/6] #0: Fix weird syntax thing --- .github/workflows/t3000-profiler-tests-impl.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/t3000-profiler-tests-impl.yaml b/.github/workflows/t3000-profiler-tests-impl.yaml index ba5330b0109..19268e77aa3 100644 --- a/.github/workflows/t3000-profiler-tests-impl.yaml +++ b/.github/workflows/t3000-profiler-tests-impl.yaml @@ -17,11 +17,7 @@ jobs: { name: "T3000 profiler tests", arch: wormhole_b0, - runs-on: - - arch-wormhole_b0 - - config-t3000 - - pipeline-perf - - ${{ inputs.extra-tag }} + runs-on: ["arch-wormhole_b0", "config-t3000", "pipeline-perf", "${{ inputs.extra-tag }}"], cmd: './tests/scripts/run_profiler_regressions.sh' }, ]