-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] Operations that reduce broadcasted tensors give incorrect results #15965
Comments
@cmaryanTT to prioritize this with @bbradelTT |
This may be related to other issues such as #12662 |
Hi @bbradelTT, could you share a rough ETA for this issue? This is a frequent blocker for Forge training efforts, so an estimate from you will help with our planning. |
@vladimirjovanovicTT it turns out that this is related to #12662, which is sufficiently unblocked, and the fix for that issue should fix this issue as well. |
Wow, great news! Thanks. |
@vladimirjovanovicTT the change was merged and post commit passes on main. Could you please pull latest main and see if this issue is resolved? |
Note that min/max for the first dims would be fixed with a different issue/pr once #16989 is merged. |
Describe the bug
Doing operations that reduce (sum, min, mean...) after having a broadcast gives incorrect results.
If the tensors match in shape the result is correct.
To Reproduce
Run the code below:
Expected behavior
The result of the operations should not be incorrect after broadcasts.
Environment information:
The text was updated successfully, but these errors were encountered: