Build is broken with precompiled headers disabled #13787
Comments
5 tasks
afuller-TT
added a commit
that referenced
this issue
Oct 15, 2024
afuller-TT
added a commit
that referenced
this issue
Oct 15, 2024
### Ticket closes #13787 needed for #13698 ### Problem description When building with PCH disabled (set `CMAKE_DISABLE_PRECOMPILE_HEADERS` to True), the build fails because not all files include the headers they use. They are only accidentally able to resolve certain dependencies. This is a problem, because the first cut of `ccache` is going to skip PCH. Also analysis tools (including the compiler) don't process non-included headers. As evidenced by the one non-include change in this PR that the compiler is now detecting. ### What's changed * Build with `CMAKE_DISABLE_PRECOMPILE_HEADERS = true` * Fix failure * GOTO step 1 ### Checklist - [x] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/11335836891) - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [x] New/Existing tests provide coverage for changes https://github.com/tenstorrent/tt-metal/actions/runs/11335836891 --------- Co-authored-by: Bryan Wilder Field Lozano <[email protected]>
yan-zaretskiy
pushed a commit
that referenced
this issue
Oct 18, 2024
### Ticket closes #13787 needed for #13698 ### Problem description When building with PCH disabled (set `CMAKE_DISABLE_PRECOMPILE_HEADERS` to True), the build fails because not all files include the headers they use. They are only accidentally able to resolve certain dependencies. This is a problem, because the first cut of `ccache` is going to skip PCH. Also analysis tools (including the compiler) don't process non-included headers. As evidenced by the one non-include change in this PR that the compiler is now detecting. ### What's changed * Build with `CMAKE_DISABLE_PRECOMPILE_HEADERS = true` * Fix failure * GOTO step 1 ### Checklist - [x] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/11335836891) - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [x] New/Existing tests provide coverage for changes https://github.com/tenstorrent/tt-metal/actions/runs/11335836891 --------- Co-authored-by: Bryan Wilder Field Lozano <[email protected]>
ct-clmsn
pushed a commit
to ct-clmsn/tt-metal
that referenced
this issue
Nov 12, 2024
…enstorrent#13700) ### Ticket closes tenstorrent#13787 needed for tenstorrent#13698 ### Problem description When building with PCH disabled (set `CMAKE_DISABLE_PRECOMPILE_HEADERS` to True), the build fails because not all files include the headers they use. They are only accidentally able to resolve certain dependencies. This is a problem, because the first cut of `ccache` is going to skip PCH. Also analysis tools (including the compiler) don't process non-included headers. As evidenced by the one non-include change in this PR that the compiler is now detecting. ### What's changed * Build with `CMAKE_DISABLE_PRECOMPILE_HEADERS = true` * Fix failure * GOTO step 1 ### Checklist - [x] [Post commit CI passes](https://github.com/tenstorrent/tt-metal/actions/runs/11335836891) - [ ] Blackhole Post commit (if applicable) - [ ] Model regression CI testing passes (if applicable) - [ ] Device performance regression CI testing passes (if applicable) - [x] New/Existing tests provide coverage for changes https://github.com/tenstorrent/tt-metal/actions/runs/11335836891 --------- Co-authored-by: Bryan Wilder Field Lozano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Build is broken with precompiled headers disabled
The text was updated successfully, but these errors were encountered: