Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model name for vLLM instantiation #71

Closed
rpavlovicTT opened this issue Jan 20, 2025 · 3 comments
Closed

Model name for vLLM instantiation #71

rpavlovicTT opened this issue Jan 20, 2025 · 3 comments

Comments

@rpavlovicTT
Copy link
Collaborator

In run_vllm_server.py script vLLM server is configured with hf_model_name as

def model_setup(hf_model_id):
    # TODO: check HF repo access with HF_TOKEN supplied
    print(f"using model: {hf_model_id}")
    args = {
        "model": hf_model_id,
...

but in vLLM TT worker implementation we have for example:

        if ("meta-llama/Meta-Llama-3.1-8B" in self.model_config.model...

setup.sh generates following vars

$HF_MODEL_REPO_ID=meta-llama/Llama-3.1-8B-Instruct
$META_MODEL_NAME=Meta-Llama-3.1-8B-Instruct

but neither of them explicitly matches string expected by vLLM... so we should consolidate these naming conventions.

@tstescoTT
Copy link
Contributor

tstescoTT commented Jan 21, 2025

FYI some WIP on this in https://github.com/tenstorrent/tt-inference-server/blob/tstesco/dev/setup.sh

Plan is to consolidate to HF repo ID, but we have some legacy model impls that differ. We can use HF model ID downstream of setup going forward.

@tstescoTT
Copy link
Contributor

I think we should be handling the *-Instruct model versions explicitly because they have different handling for tokenization and chat templating.

@tstescoTT
Copy link
Contributor

addressed in #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants