Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand verify to support weight comparisons #1310

Open
pglusacTT opened this issue Feb 24, 2025 · 1 comment
Open

Expand verify to support weight comparisons #1310

pglusacTT opened this issue Feb 24, 2025 · 1 comment

Comments

@pglusacTT
Copy link
Contributor

Currently, verify function takes in two models, calculates forward pass and then compares the outputs of those models.

For training purposes, it would be convenient to have a function that also supports weight comparisons so that we are certain that the model is training properly.

This way, we'd have an easy way to make sure that the optimizers work properly and are updating the weights in a manner that resembles the host optimizers.

@nvukobratTT
Copy link
Contributor

I.e. something to replace this and similar logic through the code (if more appear in time being):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants