From fbec92812bb8a9fd11b30ee52cbd123de046fc75 Mon Sep 17 00:00:00 2001
From: Vladimir Brkic <161027113+vbrkicTT@users.noreply.github.com>
Date: Thu, 23 Jan 2025 11:37:38 +0100
Subject: [PATCH] Log failing reason exception in pytest report xml (#1036)

Log exception details when failing reason doesn't match actual
exception.
---
 forge/test/operators/pytorch/conftest.py | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/forge/test/operators/pytorch/conftest.py b/forge/test/operators/pytorch/conftest.py
index 6ed95c6ea..58ab3fec6 100644
--- a/forge/test/operators/pytorch/conftest.py
+++ b/forge/test/operators/pytorch/conftest.py
@@ -34,6 +34,19 @@ def pytest_runtest_makereport(item: _pytest.python.Function, call: _pytest.runne
             if xfail_reason is not None:  # an xfail reason is defined for the test
                 valid_reason = FailingReasonsValidation.validate_exception(exception_value, xfail_reason)
 
-                # if reason is not valid, mark the test as failed
+                # if reason is not valid, mark the test as failed and keep the original exception
                 if valid_reason == False:
-                    report.outcome = "failed"
+                    # Replace test report with a new one with outcome set to 'failed' and exception details
+                    new_report = _pytest.reports.TestReport(
+                        item=item,
+                        when=call.when,
+                        outcome="failed",
+                        longrepr=call.excinfo.getrepr(style="long"),
+                        sections=report.sections,
+                        nodeid=report.nodeid,
+                        location=report.location,
+                        keywords=report.keywords,
+                    )
+                    outcome.force_result(new_report)
+            else:
+                logger.debug(f"Test '{item.name}' failed with exception: {type(exception_value)} '{exception_value}'")