Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated weight name in networks.utils.mlp_layers #88

Open
emailweixu opened this issue Apr 23, 2019 · 2 comments
Open

Duplicated weight name in networks.utils.mlp_layers #88

emailweixu opened this issue Apr 23, 2019 · 2 comments
Labels
type:bug Something isn't working

Comments

@emailweixu
Copy link
Contributor

The dense layers created in mlp_layers have same names:

name='/'.join([name, 'dense']) if name else None))

Because of this, eager_utils.add_variables_summaries cannot generate summary for all the weights.

@oars
Copy link
Contributor

oars commented Apr 24, 2019

Yeah, I actually just noticed this with V2 setups a day or two ago as well. It's an issue now that variables are not generated with unique names. They used to come from tf.Graph op names.

Looking at options to make them unique in V2.

@oars oars added the type:bug Something isn't working label Apr 24, 2019
@emailweixu
Copy link
Contributor Author

@oars, this problem persists even with tf2.0 rc1. Now it's not just the problem of ml_layers. EnocdingNetwork also has this problem since EncodingNetwork creates the layers itself, Do you have any problem to fix it? It's quite confusing when I want to actually examine the values and gradients of those layers.

@oars oars removed their assignment Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants