-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm chart path "fix" #3801
Comments
thallgren
added a commit
that referenced
this issue
Feb 19, 2025
The Helm chart name "telepresence-oss" was inconsistent with its contained folder "telepresence". As a result, attempts to install the chart using an argo ApplicationSet failed. The contained folder was renamed to match the chart name. This commit renames the folder and also removes old code related to "telepresence-crds". Telepresence OSS has no CRDs. Closes #3801 Signed-off-by: Thomas Hallgren <[email protected]>
Can you please try the 2.22.0-test.4 Helm chart? The matching binaries can be found here. |
thank you for the quick response, I can confirm 2.22.0-test.4 fixes the issue |
thallgren
added a commit
that referenced
this issue
Feb 21, 2025
The Helm chart name "telepresence-oss" was inconsistent with its contained folder "telepresence". As a result, attempts to install the chart using an argo ApplicationSet failed. The contained folder was renamed to match the chart name. This commit renames the folder and also removes old code related to "telepresence-crds". Telepresence OSS has no CRDs. Closes #3801 Signed-off-by: Thomas Hallgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is rather an improvements than a bug fix.
To allow telepresence-oss to be installed using argocd will require dir name change.
currently if you pull
helm pull oci://ghcr.io/telepresenceio/telepresence-oss
oci chart and untar ityou'll find
telepresence
dir and nottelepresence-oss
. While it isn't RFC that small change will allow to use gitops to install telepresence-oss.To Reproduce
add argocd application
argo wont be able to find Chart.yaml since it expects
telepresence-oss/Chart.yaml instead of telepresence/Chart.yaml
The text was updated successfully, but these errors were encountered: