diff --git a/REPORTED_ISSUES.md b/REPORTED_ISSUES.md index 7d81191..a636d6a 100644 --- a/REPORTED_ISSUES.md +++ b/REPORTED_ISSUES.md @@ -40,4 +40,10 @@ However, we have provided a [test case to verify if the labels are corrected](ht Although the Smart Speaker has been retired, we identified other projects that could benefit from the wrapper and open-sourced it on May 3rd, 2023. While we are currently maintaining the basic implementation, the previous discussion is catching up to question if we should extend the knowledge of the German Number plan to other functions as validating. -When we have further insights, we will report them as issues, re-engage with Google, and list the new issues in this file. \ No newline at end of file +When we have further insights, we will report them as issues, re-engage with Google, and list the new issues in this file. + +### 2024-05-04 - [GeoCoder labels German shared NDC 212(9) correctly but not 621(x)(y)](https://issuetracker.google.com/issues/338710341) + +BnetzA [described special case for NDC 212 and 621](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONVerzeichnisse/ONBVerzeichnis/Sonderregelungen0212_0621.pdf?__blob=publicationFile&v=1) the first one is correctly recognized by geocoder and the two cities are correctly labeled. But the second case is not recognized and only the city Mannheim is used for labeling and not Ludwigshafen. + +We have provided Ludwighafen in our labeling data. \ No newline at end of file diff --git a/pom.xml b/pom.xml index bc30c2b..19cd0b8 100644 --- a/pom.xml +++ b/pom.xml @@ -23,7 +23,7 @@ normalizer Phonenumber Normalizer Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics. - 1.1.25-SNAPSHOT + 1.2.0 jar https://github.com/telekom/phonenumber-normalizer diff --git a/src/main/resources/arealabels/nationallabels/de.json b/src/main/resources/arealabels/nationallabels/de.json index 80ca3f6..a5f8aa8 100644 --- a/src/main/resources/arealabels/nationallabels/de.json +++ b/src/main/resources/arealabels/nationallabels/de.json @@ -3243,6 +3243,11 @@ "6207": "Wald Michelbach", "6209": "Mörlenbach", "621": "Mannheim", + "6215": "Ludwigshafen", + "6216": "Ludwigshafen", + "62195": "Ludwigshafen", + "62196": "Ludwigshafen", + "62199": "Ludwigshafen", "6220": "Wilhelmsfeld", "6221": "Heidelberg", "6222": "Wiesloch", diff --git a/src/test/groovy/de/telekom/phonenumbernormalizer/PhoneAreaCodeComponentImplTest.groovy b/src/test/groovy/de/telekom/phonenumbernormalizer/PhoneAreaCodeComponentImplTest.groovy index 27426c6..a328ac5 100644 --- a/src/test/groovy/de/telekom/phonenumbernormalizer/PhoneAreaCodeComponentImplTest.groovy +++ b/src/test/groovy/de/telekom/phonenumbernormalizer/PhoneAreaCodeComponentImplTest.groovy @@ -78,6 +78,9 @@ class PhoneAreaCodeComponentImplTest extends Specification { "201" | "DE" | "Essen" "202" | "DE" | "Wuppertal" "6041" | "DE" | "Bottrop" + "60411" | "DE" | "Bottrop" + "60412" | "DE" | "XXX" + "60413" | "DE" | "Bottrop" "205" | "US" | "Alabama" "659" | "US" | "Alabama" "203" | "US" | "Connecticut" diff --git a/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy b/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy index 056d88b..92da86e 100644 --- a/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy +++ b/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy @@ -3307,7 +3307,13 @@ class PhoneNumberOfflineGeocoderTest extends Specification { "6206" | "Lampertheim" | false "6207" | "Wald Michelbach" | false "6209" | "Mörlenbach" | false - "621" | "Mannheim" | false + "621" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + // note of BnetzA, that starting number is sperating both cities: see https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONVerzeichnisse/ONBVerzeichnis/Sonderregelungen0212_0621.pdf?__blob=publicationFile&v=1 + "6215" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 + "6216" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 + "62195" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 + "62196" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 + "62199" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 "6220" | "Wilhelmsfeld" | false "6221" | "Heidelberg" | false "6222" | "Wiesloch" | false diff --git a/src/test/resources/arealabels/nationallabels/de.json b/src/test/resources/arealabels/nationallabels/de.json index 814718f..6ed4c80 100644 --- a/src/test/resources/arealabels/nationallabels/de.json +++ b/src/test/resources/arealabels/nationallabels/de.json @@ -3,6 +3,7 @@ "201": "Essen", "202": "Wuppertal", "603": "Duisburg", - "6041": "Bottrop" + "6041": "Bottrop", + "60412": "XXX" } ]