Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find references output could be more useful #21

Open
elextr opened this issue Nov 13, 2023 · 3 comments
Open

Find references output could be more useful #21

elextr opened this issue Nov 13, 2023 · 3 comments

Comments

@elextr
Copy link

elextr commented Nov 13, 2023

Find references on a function name gives a list of the files:lines where it occurs, would be good if the line content could be included to help select which to click on to goto, ie file:line: the line.

For extra credits you could generate the inset subwindow showing the list and the context of the selected item a la Vscode ... what Scintilla won't do that ... bah!!!

Screenshot from 2023-11-13 14-57-00

@techee
Copy link
Owner

techee commented Nov 13, 2023

Find references on a function name gives a list of the files:lines where it occurs, would be good if the line content could be included to help select which to click on to goto, ie file:line: the line.

Well, yeah, but it's not so simple. That would require opening each file (if not open already), dealing with various line endings to get to the correct line (or possibly feeding it to an invisible Scintilla editor) and getting those lines.

For extra credits you could generate the inset subwindow showing the list and the context of the selected item a la Vscode ... what Scintilla won't do that ... bah!!!

That one is waiting for Colomban :-).

@elextr
Copy link
Author

elextr commented Nov 13, 2023

That would require opening each file (if not open already), dealing with various line endings to get to the correct line (or possibly feeding it to an invisible Scintilla editor)

I bet thats what Vscode does, that inset is a little view on the whole file that contains the selected definition, even though that file is not open in any tabs, see the yellow compile warnings markers in the scrollbar, way below the grey line that marks current line position.

Well, that makes it much easier, just a Scintilla view inside a Scintilla view, just make annotations able to take a widget as their content, Columban would knock that up in a jiffy ;-P.

@techee
Copy link
Owner

techee commented Nov 15, 2023

So yeah, done in the non-Colomban way ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants