Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treasury:debit-interests command [15$] #1

Open
shadiakiki1986 opened this issue Dec 21, 2016 · 0 comments
Open

treasury:debit-interests command [15$] #1

shadiakiki1986 opened this issue Dec 21, 2016 · 0 comments
Labels

Comments

@shadiakiki1986
Copy link
Collaborator

shadiakiki1986 commented Dec 21, 2016

This command is supposed to generate a report called "debit interests" for the treasury department.

It has a few options such as the format required, the date to use, the accounts to include, etc.
In this report, all options are optional, with default values.
Example usage is already documented for this in the readme (the part referencing bin/ffa-old-treasury-debitInterest.php ).
Check in that file for the default values.

You will also notice there already exists a bin/ffa.php file. This is the application I started. It already contains the command treasury:debit-interests, but it's just copied from the symfony2/console documentation, so it doesn't really generate the required report. Also, I didn't add any of its options.

As a first step, please add the options needed for this command to the configure function in the treasury:debit-interest command.

Secondly, please modify the execute function also to include the original code from bin/ffa-old-treasury-debitInterest.php file.

Finally, the repository has tests that run on travis-ci. Here is the most recent build test result. You will notice that the errors are for the options date_month and accountType. There are no errors for the format option because I already added it. Let's please start by incorporating those.

PS: if you already ran a composer install, you can run the tests locally by using composer test

@shadiakiki1986 shadiakiki1986 changed the title treasury:debit-interests command treasury:debit-interests command [15$] Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants