Skip to content
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.

Fee Wallet Balance Management #17

Closed
tiero opened this issue Apr 24, 2020 · 5 comments · Fixed by #26
Closed

Fee Wallet Balance Management #17

tiero opened this issue Apr 24, 2020 · 5 comments · Fixed by #26
Assignees
Labels
enhancement New feature or request

Comments

@tiero
Copy link
Contributor

tiero commented Apr 24, 2020

  • We need to monitor the fee account with a configurable interval
  • stop accepting swap request if the balance of the fee account is too low
  • we need to WARN the daemon operator via logger this.
  • We need to expose a FeeBalance RPC in the operator grpc interface
  • We need to halt the DepostiAddres RPC if Fee account is empty
@tiero tiero added the enhancement New feature or request label Apr 24, 2020
@altafan
Copy link
Contributor

altafan commented Apr 30, 2020

We need to monitor the fee account with a configurable interval

Since a partial implementation of this has been added with #25, I'm asking if the constructor of the crawler should be updated to meet the cited requirement or if, instead, we should add an entry to the json config file to set the crawler interval.

@tiero
Copy link
Contributor Author

tiero commented Apr 30, 2020

We need to monitor the fee account with a configurable interval

Since a partial implementation of this has been added with #25, I'm asking if the constructor of the crawler should be updated to meet the cited requirement or if, instead, we should add an entry to the json config file to set the crawler interval.

@altafan
At first, I exposed the configuration to the user, but it actually depends only based on the network, and I think it's actually an overkill to expose that too. I would leave hardcoded for now.

@altafan
Copy link
Contributor

altafan commented Apr 30, 2020

ok, should we also hardcode the limit amount used to consider the fee account balance too low?

@tiero
Copy link
Contributor Author

tiero commented Apr 30, 2020

ok, should we also hardcode the limit amount used to consider the fee account balance too low?

Yes, as long it is done in a single place. Consider the equivalent amount needed for circa 5 swaps.

@altafan
Copy link
Contributor

altafan commented Apr 30, 2020

What do you mean with "5 fees per swaps"?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants