Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert_covers doesn't recurse #379

Closed
locker opened this issue May 30, 2024 · 0 comments · Fixed by #388
Closed

assert_covers doesn't recurse #379

locker opened this issue May 30, 2024 · 0 comments · Fixed by #388
Assignees
@locker
Labels
bug Something isn't working

Comments

@locker
Copy link
Member

locker commented May 30, 2024

It's really annoying that assert_covers isn't recursive:

t.assert_covers({x = 1, y = 2}, {x = 1}) -- ok
t.assert_covers({x = {a = 1, b = 2}}, {x = {a = 1}}) -- fail

This ticket is basically a duplicate of #203 but since the latter hasn't been triaged for more than two years, I created this one to draw attention to the problem.
@locker locker added the bug Something isn't working label May 30, 2024
locker added a commit to locker/tarantool-luatest that referenced this issue Aug 28, 2024
@locker
Make assert_covers recursive
badccd9 
Currently, it only checks the top-level keys. Let's make it recurse -
this will make writing tests comparing complex nested structures much
easier to write.

Closes tarantool#379
@locker locker mentioned this issue Aug 28, 2024
Merged
@locker locker assigned locker and unassigned ochaplashkin Aug 28, 2024
locker added a commit to locker/tarantool-luatest that referenced this issue Aug 28, 2024
@locker
Make assert_covers recursive
32de34f 
Currently, it only checks the top-level keys. Let's make it recurse -
this will make writing tests comparing complex nested structures much
easier to write.

Closes tarantool#379
@locker locker closed this as completed in 39da6d2 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@locker locker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make assert_covers recursive locker/tarantool-luatest
2 participants
@locker @ochaplashkin