Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MAX for varchar and varbinary size in t-sql #2302

Open
1ilit opened this issue Jan 19, 2025 · 0 comments · May be fixed by #2311
Open

Support MAX for varchar and varbinary size in t-sql #2302

1ilit opened this issue Jan 19, 2025 · 0 comments · May be fixed by #2311
Assignees
@taozhi8833998
Labels
bug Something isn't working
Milestone
5.3.7

Comments

@1ilit
Copy link

1ilit commented Jan 19, 2025

Describe the bug
Parser throws syntax error when using 'max' for varchar size

Database Engine
TransactSQL

To Reproduce
-the SQL that be parsed

CREATE TABLE [visits] ([url] varchar(max));

-the node-sql-parser version
v5.3.6
-the node version
v18.20.3

Expected behavior
Parse the sql successfully

Additional context
https://learn.microsoft.com/en-us/sql/t-sql/data-types/char-and-varchar-transact-sql?view=sql-server-ver16
@taozhi8833998 taozhi8833998 added the enhancement New feature or request label Jan 21, 2025
@taozhi8833998 taozhi8833998 added this to the 5.3.7 milestone Jan 21, 2025
@taozhi8833998 taozhi8833998 added bug Something isn't working and removed enhancement New feature or request labels Jan 23, 2025
@taozhi8833998 taozhi8833998 linked a pull request Jan 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taozhi8833998 taozhi8833998

Labels
bug Something isn't working
Projects
None yet
Milestone
5.3.7
Development

Successfully merging a pull request may close this issue.

fix: varchar and varbinary max in tsql taozhi8833998/node-sql-parser
2 participants
@taozhi8833998 @1ilit