Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make dedupe faster at I/O level. #3028

Closed
laststylebender14 opened this issue Oct 18, 2024 · 12 comments · May be fixed by #3237
Closed

feat: make dedupe faster at I/O level. #3028

laststylebender14 opened this issue Oct 18, 2024 · 12 comments · May be fixed by #3237
Labels
💎 Bounty state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.

Comments

@laststylebender14
Copy link
Contributor

Currently, for all deduplicated requests, we create a clone of the response, but we don't modify the cloned response. This results in redundant copies in memory and unnecessary overhead.

Proposed Solution:

Instead of cloning the response, we can keep a single copy of the response in memory and use it to construct the final response in synth. This approach will optimize both memory usage and performance by reducing duplication and overhead.

A similar approach has been implemented in PR #3025.

Copy link

Action required: Issue inactive for 30 days.
Status update or closure in 7 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 17, 2024
Copy link

Issue closed after 7 days of inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2024
@tusharmath
Copy link
Contributor

/bounty $120

@tusharmath tusharmath reopened this Nov 25, 2024
Copy link

algora-pbc bot commented Nov 25, 2024

## 💎 $120 bounty • Tailcall Inc.

### Steps to solve:
1. Start working: Comment /attempt #3028 with your implementation plan
2. Submit work: Create a pull request including /claim #3028 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall!
🧐 Checkout our guidelines before you get started.
💵 More about our bounty program.

Attempt Started (GMT+0) Solution
🔴 @palash25 Nov 28, 2024, 2:19:17 PM WIP
🔴 @alpha-ulrich Dec 28, 2024, 9:40:38 AM #3237

@github-actions github-actions bot removed the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Nov 25, 2024
@palash25
Copy link

palash25 commented Nov 28, 2024

/attempt #3028

Algora profile Completed bounties Tech Active attempts Options
@palash25 2 bounties from 2 projects
Go, Python,
Rust & more
Cancel attempt

Copy link

algora-pbc bot commented Nov 30, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #3028 🙌

@alpha-ulrich
Copy link

alpha-ulrich commented Dec 28, 2024

/attempt #3028

Copy link

algora-pbc bot commented Dec 29, 2024

@alpha-ulrich: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Copy link

algora-pbc bot commented Dec 30, 2024

The bounty is up for grabs! Everyone is welcome to /attempt #3028 🙌

Copy link

algora-pbc bot commented Jan 3, 2025

💡 @alpha-ulrich submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

github-actions bot commented Feb 2, 2025

Action required: Issue inactive for 30 days.
Status update or closure in 7 days.

@github-actions github-actions bot added the state: inactive No current action needed/possible; issue fixed, out of scope, or superseded. label Feb 2, 2025
Copy link

github-actions bot commented Feb 9, 2025

Issue closed after 7 days of inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty state: inactive No current action needed/possible; issue fixed, out of scope, or superseded.
Projects
None yet
4 participants