Test regarding which package to download

[julienmary]

  echo "** Installing chtcollectd ..."                                                                                                                                  
  if command_exists rpm ; then                                                                                                                                          
    CHTCOLLECT_PACKAGE="chtcollectd_v"$1".rpm"                                                                                                                          
    PACKAGE_CMD="rpm --force"                                                                                                                                           
  elif command_exists dpkg ; then                                                                                                                                       
    CHTCOLLECT_PACKAGE="chtcollectd_v"$1".deb"                                                                                                                          
    PACKAGE_CMD="dpkg"                                                                                                                                                  
  else                                                                                                                                                                  
    echo "Only supporting debian and redhat-based distributions currently" 2>&1 | tee -a /tmp/agent_install_log.txt                                                     
    abort_agent_install                                                                                                                                                 
  fi  

What a strange way to test the distro type ... What if alien is installed on a debian distro ? This depends on rpm. So that at testing rpm presence, you just test if rpm is installed, not the distro type.

It is much better to parse the file /etc/os-release to get some reliable information.