Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include() path resolution doesn't match documentation #69

Open
dbohdan opened this issue Feb 6, 2021 · 0 comments
Open

include() path resolution doesn't match documentation #69

dbohdan opened this issue Feb 6, 2021 · 0 comments

Comments

@dbohdan
Copy link

dbohdan commented Feb 6, 2021

The readme currently says,

include resolves views from relative path from executed ts / js file. (not from ejs template file).

This is either ambiguous phrasing or a mistake. Right now include calls renderFile, which calls Deno.open. Deno.open resolves paths relative to Deno.cwd(), not the template path or the executed file path. This means that changing the current directory though Deno.chdir breaks include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant