New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webgme-json-importer and use GUIDs instead of Paths for conditionals #169

Open

umesh-timalsina opened this issue Jan 31, 2022 · 1 comment

Assignees

Labels

bug dependencies

Collaborator

umesh-timalsina commented Jan 31, 2022 •

edited

Loading

Since deepforge-dev/webgme-json-importer#10, we are exporting GUIDs instead of paths for nodes. This would mean the check

electric-circuits/src/plugins/CreateElectricCircuitsMeta/CreateElectricCircuitsMeta.js

Lines 469 to 471 in 466f7ca

    
           _isModelicaPin(state) { 
        
               return state.pointers.base === this.modelicaPinState.path; 
        
           }

will no longer work.

umesh-timalsina self-assigned this

umesh-timalsina added bug dependencies labels

Collaborator

brollb commented Apr 6, 2022

If you think this should work differently in webgme-json-importer, feel free to comment here: deepforge-dev/webgme-json-importer#16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment