Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failure updating macOS client from 3.12.7 -> 3.12.8 #743

Open
gorgatron1 opened this issue Feb 8, 2025 · 12 comments
Open

failure updating macOS client from 3.12.7 -> 3.12.8 #743

gorgatron1 opened this issue Feb 8, 2025 · 12 comments
Labels
macOS

Comments

@gorgatron1
Copy link

Describe the bug
failure updating macOS client from 3.12.7 -> 3.12.8

To Reproduce

Here are the logs from the client (where I think the failure happens -- the server seems to be updated):

08-02 09:58:32.014 INFO  [ForkJoinPool.commonPool-worker-19] o.s.w.c.RestTemplate - HTTP GET http://192.168.1.138:8089/api/v1/playlists (147ms)
08-02 09:58:36.724 INFO  [JavaFX Application Thread] d.m.v.u.UpdateInfoDialogController - Downloaded https://raw.githubusercontent.com/syd711/vpin-studio/3.12.7/RELEASE_NOTES.md
08-02 09:58:36.996 INFO  [JavaFX Application Thread] d.m.v.u.UpdateInfoDialogController - Downloaded https://raw.githubusercontent.com/syd711/vpin-studio/3.12.8/RELEASE_NOTES.md
08-02 09:58:37.065 INFO  [LoadingThreadFor_1] o.s.w.c.RestTemplate - HTTP GET http://192.168.1.138:8089/api/v1/games/knowns/1 (5192ms)
08-02 09:58:37.065 INFO  [LoadingThreadFor_8] d.m.v.r.c.VPinStudioClient - Start the loading of known games for emulator 8
08-02 09:58:37.077 INFO  [LoadingThreadFor_8] o.s.w.c.RestTemplate - HTTP GET http://192.168.1.138:8089/api/v1/games/knowns/8 (12ms)
08-02 09:58:37.086 INFO  [JavaFX Application Thread] o.s.w.c.RestTemplate - HTTP PUT api/v1/preferences/json/filterSettings (3ms)
08-02 09:58:37.110 INFO  [JavaFX Application Thread] o.s.w.c.RestTemplate - HTTP GET http://192.168.1.138:8089/api/v1/pinvol/preferences (6ms)
08-02 09:58:37.298 INFO  [ForkJoinPool.commonPool-worker-23] o.s.w.c.RestTemplate - HTTP GET http://192.168.1.138:8089/api/v1/preferences/json/highscoreCardSettings (6ms)
08-02 09:58:37.304 INFO  [ForkJoinPool.commonPool-worker-5] o.s.w.c.RestTemplate - HTTP GET http://192.168.1.138:8089/api/v1/frontend/media/1201 (12ms)
08-02 09:58:37.307 INFO  [ForkJoinPool.commonPool-worker-19] o.s.w.c.RestTemplate - HTTP GET http://192.168.1.138:8089/api/v1/directb2s/1201 (15ms)
08-02 09:58:39.233 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 0
08-02 09:58:40.244 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 2
08-02 09:58:41.249 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 16
08-02 09:58:42.258 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 30
08-02 09:58:43.268 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 45
08-02 09:58:44.281 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 60
08-02 09:58:45.288 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 75
08-02 09:58:46.297 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 90
08-02 09:58:47.308 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 99
08-02 09:58:48.317 INFO  [Thread-15] d.m.v.u.UpdateDialogController - Server Update Download: 100
08-02 09:59:03.124 INFO  [Thread-15] d.m.v.r.c.VPinStudioClient - Get version failed for http://192.168.1.138:8089/
08-02 09:59:10.082 INFO  [JavaFX Application Thread] d.m.v.u.UpdateDialogController - Server updated finished to 3.12.8
08-02 09:59:10.106 INFO  [Thread-16] d.m.v.u.UpdateDialogController - Server Remote Client Download: 0
08-02 09:59:11.129 INFO  [Thread-16] d.m.v.u.UpdateDialogController - Server Remote Client Download: 7
08-02 09:59:12.138 INFO  [Thread-16] d.m.v.u.UpdateDialogController - Server Remote Client Download: 36
08-02 09:59:13.148 INFO  [Thread-16] d.m.v.u.UpdateDialogController - Server Remote Client Download: 67
08-02 09:59:14.159 INFO  [Thread-16] d.m.v.u.UpdateDialogController - Server Remote Client Download: 99
08-02 09:59:15.170 INFO  [Thread-16] d.m.v.u.UpdateDialogController - Server Remote Client Download: 100
08-02 09:59:17.801 INFO  [JavaFX Application Thread] d.m.v.u.UpdateDialogController - Server updated finished to 3.12.8
08-02 09:59:17.842 INFO  [JavaFX Application Thread] o.s.w.c.RestTemplate - HTTP PUT api/v1/preferences/json/uiSettings (36ms)
08-02 09:59:17.858 INFO  [JavaFX Application Thread] o.s.w.c.RestTemplate - HTTP GET http://192.168.1.138:8089/api/v1/preferences/json/uiSettings (16ms)
08-02 09:59:17.861 INFO  [JavaFX Application Thread] d.m.v.u.UpdateDialogController - Updater resolved OS name 'Mac OS X'
08-02 09:59:17.863 INFO  [Thread-18] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:17.863 INFO  [Thread-18] d.m.v.c.u.Updater - Downloading https://github.com/syd711/vpin-studio/releases/download/3.12.8/vpin-studio-ui-jar.zip
08-02 09:59:18.584 INFO  [Thread-18] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:18.585 INFO  [Thread-18] d.m.v.c.u.Updater - Setting tmp File at Base Path : /Users/dkoski/Library/Application Support/VPin-Studio:vpin-studio-ui-jar.zip:.bak
08-02 09:59:18.585 INFO  [Thread-18] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:18.865 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:18.866 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:18.867 INFO  [Thread-17] d.m.v.c.u.Updater - /Users/dkoski/Library/Application Support/VPin-Studio/vpin-studio-ui-jar.zip.bak download at 2%
08-02 09:59:18.867 INFO  [Thread-17] d.m.v.u.UpdateDialogController - Client Update Download: 2
08-02 09:59:19.873 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:19.873 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:19.873 INFO  [Thread-17] d.m.v.c.u.Updater - /Users/dkoski/Library/Application Support/VPin-Studio/vpin-studio-ui-jar.zip.bak download at 21%
08-02 09:59:19.873 INFO  [Thread-17] d.m.v.u.UpdateDialogController - Client Update Download: 21
08-02 09:59:20.877 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:20.877 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:20.877 INFO  [Thread-17] d.m.v.c.u.Updater - /Users/dkoski/Library/Application Support/VPin-Studio/vpin-studio-ui-jar.zip.bak download at 45%
08-02 09:59:20.877 INFO  [Thread-17] d.m.v.u.UpdateDialogController - Client Update Download: 45
08-02 09:59:21.882 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:21.882 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:21.883 INFO  [Thread-17] d.m.v.c.u.Updater - /Users/dkoski/Library/Application Support/VPin-Studio/vpin-studio-ui-jar.zip.bak download at 73%
08-02 09:59:21.883 INFO  [Thread-17] d.m.v.u.UpdateDialogController - Client Update Download: 73
08-02 09:59:22.887 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:22.887 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:22.887 INFO  [Thread-17] d.m.v.c.u.Updater - /Users/dkoski/Library/Application Support/VPin-Studio/vpin-studio-ui-jar.zip.bak download at 99%
08-02 09:59:22.887 INFO  [Thread-17] d.m.v.u.UpdateDialogController - Client Update Download: 99
08-02 09:59:23.053 INFO  [Thread-18] d.m.v.c.u.Updater - Downloaded file /Users/dkoski/Library/Application Support/VPin-Studio/vpin-studio-ui-jar.zip
08-02 09:59:23.892 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:23.892 INFO  [Thread-17] d.m.v.c.u.Updater - Setting Base Path for Mac Download to -/Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:23.893 INFO  [Thread-17] d.m.v.u.UpdateDialogController - Client Update Download: 100
08-02 09:59:26.908 INFO  [Thread-17] d.m.v.c.u.s.MacOS - Creating update script:/Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh
08-02 09:59:26.909 INFO  [Thread-17] d.m.v.c.u.s.MacOS - Writing script /Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh
08-02 09:59:26.913 ERROR [Thread-17] d.m.v.c.u.s.MacOS - Failed to create script file: ./Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh
java.nio.file.NoSuchFileException: ./Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh
	at java.base/sun.nio.fs.UnixException.translateToIOException(Unknown Source)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(Unknown Source)
	at java.base/sun.nio.fs.UnixException.rethrowAsIOException(Unknown Source)
	at java.base/sun.nio.fs.UnixFileSystemProvider.newByteChannel(Unknown Source)
	at java.base/java.nio.file.spi.FileSystemProvider.newOutputStream(Unknown Source)
	at java.base/java.nio.file.Files.newOutputStream(Unknown Source)
	at java.base/java.nio.file.Files.write(Unknown Source)
	at de.mephisto.vpin.restclient.util.FileUtils.writeBatch(FileUtils.java:174)
	at de.mephisto.vpin.commons.utils.scripts.MacOS.createScript(MacOS.java:98)
	at de.mephisto.vpin.commons.utils.scripts.MacOS.createUpdateScript(MacOS.java:53)
	at de.mephisto.vpin.commons.utils.Updater.installClientUpdate(Updater.java:151)
	at de.mephisto.vpin.ui.UpdateDialogController$3$1.call(UpdateDialogController.java:323)
	at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at javafx.graphics/javafx.concurrent.Service.lambda$executeTask$6(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at javafx.graphics/javafx.concurrent.Service.lambda$executeTask$7(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
08-02 09:59:26.913 INFO  [Thread-17] d.m.v.c.u.Updater - Exiting VPin-Studio to perform update...
08-02 09:59:26.914 INFO  [Thread-17] d.m.v.c.u.s.MacOS - Launching update script:/Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh
08-02 09:59:26.914 INFO  [Thread-17] d.m.v.c.u.s.MacOS - Using macOS base path: /Users/dkoski/Library/Application Support/VPin-Studio/
08-02 09:59:26.922 ERROR [Thread-17] d.m.v.c.u.Updater - Failed to execute update and restart: Cannot run program "/Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh" (in directory "/Users/dkoski/Library/Application Support/VPin-Studio"): error=2, No such file or directory
java.io.IOException: Cannot run program "/Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh" (in directory "/Users/dkoski/Library/Application Support/VPin-Studio"): error=2, No such file or directory
	at java.base/java.lang.ProcessBuilder.start(Unknown Source)
	at java.base/java.lang.ProcessBuilder.start(Unknown Source)
	at de.mephisto.vpin.commons.utils.scripts.MacOS.launchUpdateScript(MacOS.java:70)
	at de.mephisto.vpin.commons.utils.Updater.installClientUpdate(Updater.java:154)
	at de.mephisto.vpin.ui.UpdateDialogController$3$1.call(UpdateDialogController.java:323)
	at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
	at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
	at javafx.graphics/javafx.concurrent.Service.lambda$executeTask$6(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at javafx.graphics/javafx.concurrent.Service.lambda$executeTask$7(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.io.IOException: error=2, No such file or directory
	at java.base/java.lang.ProcessImpl.forkAndExec(Native Method)
	at java.base/java.lang.ProcessImpl.<init>(Unknown Source)
	at java.base/java.lang.ProcessImpl.start(Unknown Source)
	... 13 common frames omitted

I am not sure why it is referring to /Users/dkoski/Library/Application Support/VPin-Studio/ -- the client is installed in /Users/dkoski/pinball/VPin-Studio-Client-macosx_aarch64 but maybe the plan is to move it there?

Anyway, here is the contents of the directory -- no update-client.sh:

ls '/Users/dkoski/Library/Application Support/VPin-Studio/'
config                 resources              vpin-studio-ui-jar.zip
@karlsnyder0
Copy link
Collaborator

karlsnyder0 commented Feb 8, 2025 •
edited
Loading

@gorgatron1 Are you running the App or the legacy macOS installation (command line)?

@gorgatron1
Copy link
Author

Here is where it fails to create it but no indication what the error was:

08-02 09:59:26.909 INFO  [Thread-17] d.m.v.c.u.s.MacOS - Writing script /Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh
08-02 09:59:26.913 ERROR [Thread-17] d.m.v.c.u.s.MacOS - Failed to create script file: ./Users/dkoski/Library/Application Support/VPin-Studio/update-client.sh

The path in the second line is curious -- that leading . isn't good.

@gorgatron1
Copy link
Author

@gorgatron1 Are you running the App or the legacy macOS installation (command line)?

I guess I am probably running the legacy install -- it has been upgrading itself all along and has been in the directory where it always was.

@karlsnyder0
Copy link
Collaborator

karlsnyder0 commented Feb 8, 2025 •
edited
Loading

@gorgatron1 Are you running the App or the legacy macOS installation (command line)?

I guess I am probably running the legacy install -- it has been upgrading itself all along and has been in the directory where it always was.

Understood.

This is likely a bug, however would you be interested in running the App? I can see the legacy installer being deprecated. Now that we have a working app IMO we should continue spending our efforts there.

@gorgatron1
Copy link
Author

Sure, I can switch to it. The legacy installer is actually easier for me, but I know it isn't for everyone.

@karlsnyder0
Copy link
Collaborator

Sure, I can switch to it. The legacy installer is actually easier for me, but I know it isn't for everyone.

It is easier? What makes it easier? We might want to continue support if there is value in the command line over the App.

@gorgatron1
Copy link
Author

Well, I am a developer so running things from the command line (Terminal) is super easy. I like the fact that it can update itself and I don't need to manually download dmgs and mess with the quarantine:

ls -l@ /Applications/VPin-Studio.app/Contents/MacOS/VPin-Studio 
-rwxr-xr-x@ 1 dkoski  admin  180192 Feb  7 22:32 /Applications/VPin-Studio.app/Contents/MacOS/VPin-Studio
	com.apple.quarantine	    57 

xattr -d com.apple.quarantine /Applications/VPin-Studio.app/Contents/MacOS/VPin-Studio

but most Mac users probably aren't using the command line so this isn't as convenient for them.

@gorgatron1
Copy link
Author

Don't keep it around just for me!

@gorgatron1
Copy link
Author

Oh and maybe the .app will update itself -- that would explain downloading the .jar to that Application Support directory

@karlsnyder0
Copy link
Collaborator

Oh and maybe the .app will update itself -- that would explain downloading the .jar to that Application Support directory

The App should update itself.

@gonzonia
Copy link
Collaborator

gonzonia commented Feb 9, 2025 •
edited
Loading

There was a bug in 3.12.7 that prevented the app from updating itself. Please install 3.12.8 manually. Going forward it will update itself (unless we missed something).

Edit to add: Hopefully, the quarantine is just a one-time thing at the initial download/install. Once it is installed and updating itself correctly you shouldn't have to do that.

@gonzonia gonzonia added the macOS label Feb 9, 2025
@gonzonia
Copy link
Collaborator

@gorgatron1 Can you confirm this is now working as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
macOS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karlsnyder0 @gonzonia @gorgatron1