Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVOffset Validator Check #606

Open
spaceangel1970 opened this issue Nov 18, 2024 · 2 comments
Open

NVOffset Validator Check #606

spaceangel1970 opened this issue Nov 18, 2024 · 2 comments

Comments

@spaceangel1970
Copy link

Before the latest Studio Patch 3.10.1 the validator was picking up any table with a missing offset once the first one is set.
When updating tables that have an offset originally it will flag there is one missing.

@syd711
Copy link
Owner

syd711 commented Nov 18, 2024

Is a follow up of #599

@syd711
Copy link
Owner

syd711 commented Nov 18, 2024

gorgatron — Today at 4:03 PM
FWIW I think the rules around NVOffset go like this:

  • an NVOffset of 0 (or not set) when other tables for the same rom have something set is wrong -- it won't switch the nv files
  • two vpx files that have the same NVOffset are going to share the same high scores etc.
  • almost certainly you don't want two tables with different gameId (VPS) to share the same high scores (e.g. Dr. Who and Dr. Strange)
    -but you might have different authors of the same table (e.g. VPW and Ext2k) that you do want to have the same NVOffset (this is the specific issue I filed -- these files are both trying to simulate the same table per VPS)

The first rule we definitely want to be warned about. The second is just how it works and really the last two are what policy you want -- those two are my opinion based on how I have NVOffset working (now that I understand it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants